Add callback for when a submenu is opened #6439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nekodex
force-pushed
the
add-submenu-open-callback
branch
from
a494418 to
fdd15cd
Compare
2 tasks
frenzibyte
reviewed
Nov 30, 2024
Comment on lines
+586
to
+588
| // Check if submenu has changed before firing, to prevent extraneous callbacks (e.g. re-hovering the triggeringItem of an already open submenu) | ||
| if (submenuChanged) | ||
| OnSubmenuOpen?.Invoke(submenu); |
There was a problem hiding this comment.
Sounds like you want to be triggering this event inside the conditional above in the else branch where the submenu was closed and becomes open?
There was a problem hiding this comment.
The problem is that submenu gets reused (assumedly as an optimisation?), so in some cases the state is already set to 'open' and the item list just gets updated (e.g. switching between menus in EditorMenuBar)
peppy
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be used by lazer for improved menu audio feedback (ppy/osu#30910)