Check for updates button doesn't check for updates

[peppy]

Seems to do nothing.

[frenzibyte]

Looks to work fine on my end. Both on macOS and Windows with Squirrel, even with removing the automatic update checking at UpdateManager.LoadComplete().

[peppy]

I can still reproduce it not checking at my end:

2021-04-13_01-58-50.mp4

Haven't had a chance to look into it further yet.

[peppy]

I've further tested this on macOS and can't reproduce the issue. It's likely some kind of web request caching logic within Squirrel if anything.

For what it's worth, this came up when i had osu! already running and pushed a new release. Pressing the "Check for updates" button had no effect, but restarting the game found the update immediately.

[Joehuu]

Having the same issue on macOS. Not sure if it's the same cause as yours, but upon checking https://api.github.com/repos/ppy/osu/releases/latest, this is returned. Haven't done anything weird, apart from installing old versions to reproduce a unrelated bug.

{"message":"API rate limit exceeded for <IP>. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)","documentation_url":"https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting"}

Seems realistic to get this because of the limit, though (https://docs.github.com/en/rest/overview/resources-in-the-rest-api#rate-limiting):

For unauthenticated requests, the rate limit allows for up to 60 requests per hour. Unauthenticated requests are associated with the originating IP address, and not the user making requests.

---

After an hour, everything works again. Doing some experiment, I pressed that button 60 times before it stopped working again.

[peppy]

That's a different issue altogether, but also one we likely want to address. Were you clicking the button or restarting osu! a lot when this happened?

[Joehuu]

I never pressed the button until I realized there was no update notification at the start when testing older releases, and I don't think I restarted osu! that much.

Only thing I can think of is that other apps I was using at the time were using the api (e.g. some VSCode extension), and I can remember restarting that an abnormal amount of times.

[peppy]

Yeah, quite feasible since it's per IP at that point. The eventual plan would be to not rely on github in the first place for these calls, but we could consider creating an access key for the client to bypass the rate limiting.