Editor Test Play never exits when starting from a different time

[LeNitrous]

Type

Game behaviour

Bug description

• Reproduction Steps:

  • Open any beatmap in editor
  • Advance the time to any time greater than the first hit object
  • Open test play and complete the beatmap

• Cause:

  • This is because EditorPlayer relies on ScoreProcessor.HasCompleted to check whether a map has been completed or not. However, the check works if all hit objects have been judged and this is never true for the case when the beatmap starts at a different time.

hasCompleted.Value =
    JudgedHits == MaxHits
    && (JudgedHits == 0
        // Last applied result is guaranteed to be non-null when JudgedHits > 0.
        || lastAppliedResult.AsNonNull().TimeAbsolute < Clock.CurrentTime);

Screenshots or videos

osu._z3NeWZundY.mp4

Version

2022.319.0

Logs

N/A

[peppy]

This is a weird one, because somehow SpectatorPlayer manages to avoid the issue, but I can't immediately find the logic making it work there..

[bdach]

I'm guessing that spectator player exit is driven by EndPlaying() calls rather than beatmap completion.

[peppy]

Is what I thought, but I couldn't immediately find this flow. It looks to be relying on the same bindable as mentioned in this thread and works as expected. I have a feeling hitobjects are getting results populated somewhere.

[smoogipoo]

In spectator, ScoreProcessor gets replay frames applied to it which updates JudgedHits:

osu/osu.Game/Rulesets/UI/RulesetInputManager.cs

Lines 87 to 89 in cda46ec

	case ReplayStatisticsFrameEvent statisticsStateChangeEvent:
	scoreProcessor?.ResetFromReplayFrame(ruleset, statisticsStateChangeEvent.Frame);
	break;