Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't move timing point using "Use current time" #23147

Closed
reo-the-enby opened this issue Apr 6, 2023 · 1 comment · Fixed by #29532
Closed

Can't move timing point using "Use current time" #23147

reo-the-enby opened this issue Apr 6, 2023 · 1 comment · Fixed by #29532
Assignees
Labels
area:editor priority:1 Very important. Feels bad without fix. Affects the majority of users. type:behavioural

Comments

@reo-the-enby
Copy link

Type

Game behaviour

Bug description

Moving back in the timeline and then clicking a timing point moves you

Screenshots or videos

Skarminspelning.2023-04-06.kl.10.32.18.mov

Version

2023.403.1

Logs

.

@smallketchup82
Copy link
Contributor

smallketchup82 commented Feb 12, 2024

The timing editor currently tracks the control point left of the timeline clock.

I think that the easiest way to fix this (to an extent) is to change tracking behaviour to track the nearest control point to the clock. This would allow for more manoeuvrability but would also be bad if you want to, say, move the control point to the other end of the map.

Another way to go about it is to move the button to a right click menu. This allows for updating the position of the control point to basically anywhere in the map, but also require more effort than the other method to implement.

The last way that I thought of, is to remove the tracking system and instead change the behaviour of the control point rows. Similar to #23197 but without the "locking system". To select a control point, you click it in the table. To seek to it, you double click it in the table. The tracking system is modified to instead of selecting the beatmap left of the cursor, it simply highlights it in the control point table to show which control point you're in the domain of. This allows you to go back to a control point to edit it without having to change position & fixes the issue of moving timing points.

I personally think that the first one would be good enough for most use cases. The second one would provide a complete fix but would take longer to implement vs the first solution. The third one makes the timing editor feel more like the typical NLE, and consequently pave the way for #23105 to be implemented, but is really extreme when considering the scope of this specific issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editor priority:1 Very important. Feels bad without fix. Affects the majority of users. type:behavioural
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants