Fix difficulty icon tooltip not displaying duration above 1 hour correctly #30613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdach
requested changes
Nov 13, 2024
|
yes |
|
i believe this is what you meant? |
|
This should use |
|
ok |
bdach
requested changes
Nov 13, 2024
| @@ -146,7 +146,10 @@ public void SetContent(DifficultyIconTooltipContent content) | |||
| approachRate.Text = @" AR: " + adjustedDifficulty.ApproachRate.ToString(@"0.##"); | |||
| overallDifficulty.Text = @" OD: " + adjustedDifficulty.OverallDifficulty.ToString(@"0.##"); | |||
|
|
|||
| length.Text = "Length: " + TimeSpan.FromMilliseconds(displayedContent.BeatmapInfo.Length / rate).ToString(@"mm\:ss"); | |||
| TimeSpan lengthTimeSpan = TimeSpan.FromMilliseconds(displayedContent.BeatmapInfo.Length / rate); | |||
| length.Text = "Length: " + (lengthTimeSpan.Hours > 0 | |||
There was a problem hiding this comment.
This is not correct. Counterexample: try any timespan which is a multiple of 24 hours. You would want
Suggested change
| length.Text = "Length: " + (lengthTimeSpan.Hours > 0 | |
| length.Text = "Length: " + (lengthTimeSpan.TotalHours >= 1 |
See docs to understand the difference.
Then again, as above, there's an established helper for this already.
Hiviexd
reviewed
Nov 13, 2024
| @@ -146,7 +146,10 @@ public void SetContent(DifficultyIconTooltipContent content) | |||
| approachRate.Text = @" AR: " + adjustedDifficulty.ApproachRate.ToString(@"0.##"); | |||
| overallDifficulty.Text = @" OD: " + adjustedDifficulty.OverallDifficulty.ToString(@"0.##"); | |||
|
|
|||
| length.Text = "Length: " + TimeSpan.FromMilliseconds(displayedContent.BeatmapInfo.Length / rate).ToString(@"mm\:ss"); | |||
| TimeSpan lengthTimeSpan = TimeSpan.FromMilliseconds(displayedContent.BeatmapInfo.Length / rate); | |||
| length.Text = "Length: " + (lengthTimeSpan.Hours > 0 | |||
There was a problem hiding this comment.
something like this would be cleaner
length.Text = "Length: " + lengthTimeSpan.ToString(lengthTimeSpan.TotalHours >= 1 ? @"hh\:mm\:ss" : @"mm\:ss");
bdach
changed the title
bdach
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this will fix #30612, but as a downside, it will always show the hour.