Account for rate changing mods when disabling the "Ready" button #30929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timschumi
commented
Nov 30, 2024
timschumi
commented
Nov 30, 2024
timschumi
commented
Nov 30, 2024
|
Tests would be good to see here. You said you wanted help with that but not sure with what specifically? |
Mainly just general unfamiliarity with the testing framework, starting even from the very basic question of "should this be tested headless or not?". It will take me a few days to read into it, but I'll get there at some point. |
Either is fine, but headless is probably slightly better in this case. |
|
It's not super easy to test because of the track, so I've gone ahead and added some tests for you. |
smoogipoo
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I managed to gather enough resolve to enable DTNF to save my streak, the game better let me do it.
Writing tests is something that I haven't figured out yet, help much appreciated.