Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do we want to allow extending "parts of the page"? #2

Closed
pradyunsg opened this issue Mar 14, 2021 · 2 comments
Closed

How do we want to allow extending "parts of the page"? #2

pradyunsg opened this issue Mar 14, 2021 · 2 comments
Labels
type: discussion Discussion of general questions, ideas, design, etc.

Comments

@pradyunsg
Copy link
Owner

Right now, I've taken the approach of having a Jinja2 block that "wraps" an include of a template file named elements/{whatever}.html. The wrapper tags have classes that are directly used in the skeleton.css file.

This is what it looks like right now:

{% block content_sidebar %}
<aside class="sb-content-sidebar">
{% include "elements/content-nav.html" %}
</aside>
{% endblock %}

@choldgraf
Copy link
Contributor

that seems reasonable to me 👍 perhaps we should close this issue once this is documented?

@pradyunsg
Copy link
Owner Author

This now has a placeholder in the documentation, and likely doesn't need a dedicated issue to track filling that placeholder. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: discussion Discussion of general questions, ideas, design, etc.
Projects
None yet
Development

No branches or pull requests

2 participants