Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How do we want to share CSS/SCSS across themes? #3

Closed
pradyunsg opened this issue Mar 14, 2021 · 4 comments
Closed

How do we want to share CSS/SCSS across themes? #3

pradyunsg opened this issue Mar 14, 2021 · 4 comments
Labels
type: discussion Discussion of general questions, ideas, design, etc.

Comments

@pradyunsg
Copy link
Owner

Ideally, we'd only have a single CSS file get included in the final theme-built-pages (assuming no CSS comes from extensions or the users).

I have no idea how we'd achieve this, or whether this is something that we agree would be a worthwhile investment of effort. :)

@pradyunsg pradyunsg added the type: discussion Discussion of general questions, ideas, design, etc. label Mar 14, 2021
@pradyunsg
Copy link
Owner Author

@chrisjsewell @choldgraf Any bright ideas for this one?

@choldgraf
Copy link
Contributor

mmm TBH I'm not sure how we'd accomplish this. What is the main downside between this vs. having sub-themes just have their own CSS files?

@pradyunsg
Copy link
Owner Author

pradyunsg commented Apr 1, 2021

Asset sharing mainly. With this it would be much easier to have like some subset of the other theme, especially if that other theme is using Sass and compiling down to CSS.

The example use case I’m designing for is... a different theme being able to use Furo’s sidebar styling or Furo’s content styling without duplication of that Sass, or needing to break up the CSS into multiple files in Furo.

@pradyunsg
Copy link
Owner Author

I'm gonna kick the can for this into sphinx-theme-builder. This needs some mechanism for a JS bundler <-> Python package installation path integration, and having that be somewhere around the build system makes more sense than a base theme that folks derive from.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: discussion Discussion of general questions, ideas, design, etc.
Projects
None yet
Development

No branches or pull requests

2 participants