-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a left and right topbar section (maybe a middle one as well?) #6
Comments
Yup yup. My thought process is that this would be what the default wrapper would provide. I just didn't have enough time to write it all down. 🙃 |
Bringing this over from the above issue:
Actually, I had a bit of a different idea for this:
This is much easier to maintain upstream thanks to fewer points to interact with downstream themes and it is easier to adapt for RTL languages as well. |
interesting - that seems reasonable from an end-user standpoint, though I must admit that it seems complicated to implement from my perspective. If you think it's more straightforward though, then go for it :-) |
Flexbox FTW! https://css-tricks.com/snippets/css/a-guide-to-flexbox/#justify-content Just need to have |
wow that's cool - so then from a theme developer's standpoint, you'd need to document that "any Also just a note that what I've seen more-commonly than having the center |
The
Or
And they'll get aligned as the names suggest. :) |
makes sense - so basically a sub-theme would:
and if they added in a third div, then the middle div would be middle-centered. or maybe more generally the divs would have the same width and spread evenly? |
Yes, if the left and right are the same width. Otherwise the middle item will be slightly off.
Not the width but yea, spread evenly. |
Closing this out, since downstream themes should be able to do this on their own, through regular margin shenenigans/floats/flexbox; and I'd prefer to give them more direct control. |
It is common to have topbar content that is both justified to the left and justified to the right. Other themes also include a "center topbar" section that aligns with the page content.
How could we accommodate these different workflows?
For example:
pydata sphinx theme uses left, center, and right topbar areas:
gitbook theme uses left, center, and right topbar areas:
quantecon theme uses left, and right topbar areas:
The text was updated successfully, but these errors were encountered: