Raise error for colors with leading # #869
Conversation
|
Nice! Thanks for the PR! First off please add an entry to the change log so we can doc the updated behavior. Also I'm not sure that checking for the length of the string will be enough, as someone could say pass when String
if color =~ /\A[0-F]{6}\z/i
:RGB
else
raise ArgumentError, "Unknown type of color: #{color.inspect}"
endThanks again! |
|
Good call! I wasn't thinking about the actual string content, I'll update both of those |
|
I'm just going to close this because it's probably no longer valid |
|
Hey I missed that you updated this branch, if you are still interested in getting it in I'm open to merging. Thanks! |
tomprats
force-pushed
the
invalid-color-format
branch
4 times, most recently
from
f4fd788 to
cbf476b
Compare
|
@packetmonkey Thanks! Should be good to go now |
manual/graphics/color.rb
Outdated
| @@ -10,7 +10,7 @@ | |||
| Prawn::ManualBuilder::Example.generate(filename) do | |||
| stroke_axis | |||
|
|
|||
| # Fill with Yellow using RGB | |||
| # Fill with Yellow using RGB (Unlink css, there is no leading #) | |||
tomprats
force-pushed
the
invalid-color-format
branch
from
cbf476b to
4858753
Compare
| @@ -94,7 +94,11 @@ def process_color(*color) | |||
| def color_type(color) | |||
| case color | |||
| when String | |||
| :RGB | |||
| if color =~ /\A[0-F]{6}\z/i | |||
There was a problem hiding this comment.
There are a few characters that we probably don't want to match between '9' and 'A'. I'd prefer this regex to be something more specific. For example /\A[0-9a-f]{6}\z/i.
|
@tomprats If you're steal interested, please address my comment and rebase your branch on master. Thank you. |
pointlessone
force-pushed
the
master
branch
2 times, most recently
from
3c5df3e to
8309626
Compare
|
@tomprats Than you for your contribution. I've rebased this PR on master and merged. GitHub didn't pick it up so I will close it now. |
|
@pointlessone Thanks! Sorry I never got around to making the extra changes |
Saw this issue and thought I could help! Really appreciate all the work you guys do!