fix centerOnInit timing issue #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's give it a try 👍 |
|
Thanks! 🚀 |
|
🎉 This PR is included in version 3.4.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses this issue: #392
It seems like, maybe depending on what html and CSS you are using in the code surrounding your image, the
contentComponentwill trigger theResizeObservermultiple times before the image is actually loaded. Given that theResizeObserveris coded to only run once, this leaves the image off-center in some cases.I've set it up so that the
ResizeObserverwill wait until thecontentComponentheight or width becomes greater than 0 before triggering thesetCenterfunction. The timeout ensures that the observer will eventually disconnect if a resize never happens. I wasn't sure how long to set that for but 5 seconds seemed reasonable.