-
-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No support for pycodestyle #319
Comments
I wasn’t aware of that. Have you got a link? |
as far as I can tell it's not deprecated. pycodestyle isn't a replacement for pyflakes + the plugin architecture. it just hasn't received an update in a while. I've offered to pick up some maintenance but haven't heard back. I guess I'll email the mailing list? |
My mistake, pep8 was renamed to pycodestyle. |
I get identical failure on all hooks like this
|
1.2.3 is pretty old, does that reproduce with 1.4.0? I've seen that error in the past -- but it was supposed to be fixed with: Lines 27 to 29 in 78b2443
|
Yes, it does. |
@blaggacao weird...
can you show me those commands but in your environment? also probably |
@asottile wired ineed:
Key is: https://gist.github.com/blaggacao/8b9285898486f1d348ec1ae3a0533c17 |
That is so strange! What does Is there maybe also anything matching |
|
How about (I hope I typed this right on my phone) |
Oha, that's a nice one 😉
|
That still looks fine too... This is quite the puzzler. Maybe we can look inside the hook env, there should be a couple of repo* dirs in Wow I wish I could debug this in person hah |
In the one that just failed:
|
Aha! |
But how did it get there? lol flake8 restricts the version to be |
I bet it's something to do with both autopep8 and flake8 being in the environment. Let me make a branch I've been meaning to make for a while and then I'll give you something to try |
@blaggacao can you try this branch: #321 Here's a config: - repo: https://github.com/pre-commit/pre-commit-hooks
rev: 526904b1596ea461616a7b8b20ebd959454b57fc
hooks:
- id: trailing-whitespace
# ... |
Looks good: (the error seems due to my exceptional naming)
|
I'm also trying to replicate in docker -- I suspect the difference between my environment and yours is I'm using a virtualenv and you've installed |
I guess, so:
|
bingo! that's what it is:
probably debian's packaging of If I
|
@blaggacao pre-commit-hooks v2.0.0 has been released which contains the fix for that 🎉 -- thanks again for the detailed report and the back and forth! |
@asottile Thanks! You're welcome! Such (rare) responsiveness was great fun, also on this end. |
I think (?) this is less relevant now that I've released flake8 3.6.0 🎉 otherwise, feel free to reopen :) |
flake8 was officialy deprecated and mostly replaced by pycodestyle which is currently does not have a pre-commit-hook.
Initially I was considering repurposing the flake8 hook but I think it will be better to have a new one as doing the swap may also involve renaming its section inside
setup.cfg
ortox.ini
.The text was updated successfully, but these errors were encountered: