-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
onFocusIn and onFocusOut events incorrectly set #4314
Comments
Heh, I did not think this would be a thing but |
The DOM is wonderful at times 😉 Here is a failing test that can be added to it('should support camel-case focus event names', () => {
render(<div onFocusIn={() => {}} onFocusOut={() => {}} />, scratch);
expect(proto.addEventListener)
.to.have.been.calledTwice.and.to.have.been.calledWith('focusin')
.and.calledWith('focusout');
}); |
Looks like the attribute exists in WebKit but not Chrome or FF, do we just need to give them a little push? I've had to do that in the past for FF a couple times. Edit: Asking as I cannot find any justification for why |
@JoviDeCroock Amazing pace of fixing this and 4221! 💯 🥳 |
Describe the bug
The changing in casing of the
onfocusin
andonfocusout
attributes toonFocusIn
andonFocusOut
in 4307, introduced in 10.19.7, breaks those types of event listeners.To Reproduce
focusin
event listener is never triggered.Inspecting the element using dev tools, the
onFocusIn
attrbute creates an event listener for the non standardFocusIn
event instead offocusin
.Expected behavior
The same behavior of setting
onFocusIn
as the previousonfocusin
, meaning event listeners for thefocusin
since the latter has been removed from the declaration file.
The text was updated successfully, but these errors were encountered: