diff --git a/modules/prebidServerBidAdapter/index.js b/modules/prebidServerBidAdapter/index.js index 9c8b157b008..c0df936055d 100644 --- a/modules/prebidServerBidAdapter/index.js +++ b/modules/prebidServerBidAdapter/index.js @@ -888,7 +888,7 @@ const OPEN_RTB_PROTOCOL = { bidObject.meta = bidObject.meta || {}; if (bid.adomain) { bidObject.meta.advertiserDomains = bid.adomain; } - // TODO: Remove when prebid-server returns ttl and netRevenue + // the OpenRTB location for "TTL" as understood by Prebid.js is "exp" (expiration). const configTtl = s2sConfig.defaultTtl || DEFAULT_S2S_TTL; bidObject.ttl = (bid.exp) ? bid.exp : configTtl; bidObject.netRevenue = (bid.netRevenue) ? bid.netRevenue : DEFAULT_S2S_NETREVENUE; diff --git a/src/adapterManager.js b/src/adapterManager.js index 92cb99553fb..5664c6262da 100644 --- a/src/adapterManager.js +++ b/src/adapterManager.js @@ -306,7 +306,6 @@ adapterManager.makeBidRequests = hook('sync', function (adUnits, auctionStart, a bidRequest['uspConsent'] = uspDataHandler.getConsentData(); }); } - return bidRequests; }, 'makeBidRequests'); diff --git a/test/spec/unit/core/adapterManager_spec.js b/test/spec/unit/core/adapterManager_spec.js index d24e661c739..bd3451de648 100644 --- a/test/spec/unit/core/adapterManager_spec.js +++ b/test/spec/unit/core/adapterManager_spec.js @@ -767,7 +767,7 @@ describe('adapterManager tests', function () { 'start': 1462918897460 }, { - 'bidderCode': 'rubicon', + 'bidderCode': 'pubmatic', 'auctionId': '1863e370099523', 'bidderRequestId': '2946b569352ef2', 'tid': '2342342342lfi23', @@ -788,7 +788,7 @@ describe('adapterManager tests', function () { ], 'bids': [ { - 'bidder': 'rubicon', + 'bidder': 'pubmatic', 'params': { 'placementId': '543221', 'test': 'me' @@ -827,7 +827,7 @@ describe('adapterManager tests', function () { ], 'bids': [ { - 'bidder': 'rubicon', + 'bidder': 'pubmatic', 'params': { 'placementId': '5324321' }, @@ -853,7 +853,7 @@ describe('adapterManager tests', function () { ], 'bids': [ { - 'bidder': 'rubicon', + 'bidder': 'pubmatic', 'params': { 'placementId': '4799418', 'test': 'me' @@ -877,7 +877,7 @@ describe('adapterManager tests', function () { 'transactionId': '4r42r23r23' }, { - 'bidder': 'rubicon', + 'bidder': 'pubmatic', 'params': { 'placementId': '4799418' },