Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserId module - invalid refreshInSeconds value silently ignored #11869

Closed
abazylewicz-id5 opened this issue Jun 26, 2024 · 0 comments · Fixed by #11872
Closed

UserId module - invalid refreshInSeconds value silently ignored #11869

abazylewicz-id5 opened this issue Jun 26, 2024 · 0 comments · Fixed by #11872
Assignees

Comments

@abazylewicz-id5
Copy link
Contributor

abazylewicz-id5 commented Jun 26, 2024

Type of issue

question/possibly a bug

Description

When the partner sets refreshInSeconds value which is not a number (eg. a string with a number "3600", or even a string with number operation like "8 * 3600") it seems to be silently ignored by the userId module. Maybe a log warning/error should be issued?

We have a correct value in our examples, also we reached out to our partners that have incorrect configuration, but we still see a steady stream of incorrect values.

Steps to reproduce

Use a userId module with a string refreshInSeconds:

pbjs.setConfig({
  userSync: {
    userIds: [{
      name: 'id5Id',
      params: {
        partner: 173,           
      },
      storage: {
        type: 'html5',         
        name: 'id5id',     
        expires: 90,            
        refreshInSeconds: "7200"   // some partners use the string value for refreshInSeconds for some reason
      }
    }],
    auctionDelay: 50           
  }
});
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants