bidderFactory sends wrong sync params to the bidders

[dmitriyshashkin]

Type of issue

Bug

Description

I tried to enable user sync through frames so I've added the following setConfig call:

pbjs.setConfig({ userSync: {
    iframeEnabled: true
}});

The "userSync" module combines default setting with those passed in setConfig. If the user hasn't specified some option, it would retain its default value.

config.getConfig('userSync', (conf) => {
    usConfig = Object.assign(usConfig, conf.userSync);
});

But the "bidderFactory" does not store the initial settings, instead, it asks the "config" for the current version of those settings.

let syncs = spec.getUserSyncs({
    iframeEnabled: config.getConfig('userSync.iframeEnabled'),
    pixelEnabled: config.getConfig('userSync.pixelEnabled'),
}, responses);

Config modules does not apply the default settings. And if the user hasn't specified some option, it would be undefined and undefined is treated as false. Upon the first call to "setConfig" the default values are discarded. In my case, pixelEnabled became undefined. So enabling iframe sync disabled pixel sync.

I'd say that the handling of the default values should be done in the config.

Steps to reproduce

1. Add the following funtion call at the init pbjs.setConfig({ userSync: {iframeEnabled: true}});
2. Run an auction with some bidders that use pixel sync (conversant, trustX)

Expected results

Sync pixels for those bidders are fired

Actual results

Sync pixels for those bidders are not fired

Platform details

pbjs v 0.33

[mkendall07]

@dmitriyshashkin
Thanks for reporting. Will take a look at this.