From e6e5f4ab3d76b86c4723b1e4ce2dd6ea98f51fb9 Mon Sep 17 00:00:00 2001 From: fawke Date: Wed, 16 Sep 2020 19:58:12 +0530 Subject: [PATCH] add guideline to check for GVL ID --- PR_REVIEW.md | 1 + 1 file changed, 1 insertion(+) diff --git a/PR_REVIEW.md b/PR_REVIEW.md index 9a57539a0cd..d7703cf20ae 100644 --- a/PR_REVIEW.md +++ b/PR_REVIEW.md @@ -24,6 +24,7 @@ For modules and core platform updates, the initial reviewer should request an ad - If they support SChain, add `schain_supported: true` - If their bidder doesn't work well with safeframed creatives, add `safeframes_ok: false`. This will alert publishers to not use safeframed creatives when creating the ad server entries for their bidder. - If they're setting a deal ID in some scenarios, add `bidder_supports_deals: true` + - If they have an IAB Global Vendor List ID, add `gvl_id: ID`. There's no default. - If all above is good, add a `LGTM` comment and request 1 additional core member to review. - Once there is 2 `LGTM` on the PR, merge to master - Ask the submitter to add a PR for documentation if applicable.