Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace PostScribe in the PUC #1018

Closed
bretg opened this issue Jul 2, 2024 · 2 comments · Fixed by prebid/prebid-universal-creative#246
Closed

Replace PostScribe in the PUC #1018

bretg opened this issue Jul 2, 2024 · 2 comments · Fixed by prebid/prebid-universal-creative#246

Comments

@bretg
Copy link
Contributor

bretg commented Jul 2, 2024

The Prebid Universal Creative has been using the PostScribe library for rendering in mobile for many years. PostScribe is deprecated.

This is the relevant code in the PUC is https://github.com/prebid/prebid-universal-creative/blob/master/src/postscribeRender.js

We need someone who understands mobile webviews to step up and help Prebid figure out what's going on here.

Options:

  1. PostScribe was a nice-to-have that we can live without. Just remove it from the PUC and write directly to the iframe body with javascript.
  2. No, webviews really do need an asyncronous way to write or it will negatively impact the user experience. We need to update the PUC to replace PostScribe with ____.

@alexsavelyev - please discuss with the mobile committee, which owns this part of the PUC.

@justadreamer
Copy link

justadreamer commented Jul 4, 2024

I think we need to carefully consider option 2, but not from the mobile native webviews perspective. Mobile native webviews can do synchronous writes and it would not impact the user experience or performance, because:

  • there is nothing else to render in an ad webview in a native mobile app anyway - so no content we are preventing with a synchronous write
  • on modern mobile OSes rendering runs out-of-process and on older mobile OSes it runs on a separate thread in-process - so not impacting the performance of the outside app

However asynchronous writing might be needed for AMP, because it seems to be also relying on writeAdHtml call imported from postscribeRender.js. There it might have an impact on user experience - for it might delay some other content rendering. However can't comment deeper on AMP due to a lack of expertise.

So it may be the case that for mobile native we can just do a synchronous write, while for amp we'd still need to seek another solution - further code bifurcation..

@bretg
Copy link
Contributor Author

bretg commented Jul 8, 2024

Thanks for moving this forward @justadreamer. I'd say it would be fine to use a different write routine in the PUC for mobile-vs-AMP.

I rather doubt anyone's going to step up and offer to fix AMP rendering for us. Seems to be a decaying platform. If mobile doesn't need async writes, we should divorce them from PostScribe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants