Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Multi-Imp requests #1604

Closed
curlyblueeagle opened this issue Dec 1, 2020 · 3 comments
Closed

Question: Multi-Imp requests #1604

curlyblueeagle opened this issue Dec 1, 2020 · 3 comments
Assignees
Labels

Comments

@curlyblueeagle
Copy link
Contributor

@SyntaxNode In a prior PR you had suggested for 33Across adapter to handle multi-imp requests by breaking them up into multiple http requests #1557 (comment)

We are in the process of implementing this suggestion. However, I have a question for you. How would Prebid Server handle the individual bid responses and associate them with the incoming mult-imp bid request? The adapter will of course pass the Imp ID in each of the bid response during MakeBids. Will this be sufficient? Does the adapter need to do anything more?

@bretg
Copy link
Contributor

bretg commented Dec 7, 2020

Not sure how this works technically. @SyntaxNode ?

@SyntaxNode
Copy link
Contributor

@curlyblueeagle Yes, that will be sufficient.

Prebid Server will call your adatper's MakeBids method once for each response received and combine the bids from all of those calls together as a single OpenRTB Seat Bid for your adapter. I recommend you perform end-to-end testing to make sure it looks right when all is said and done, but I don't anticipate any problems.

FYI: The code for this behavior is found in exchange/bidder.go in the requestBid method if you'd like to explore the logic further. Look for the for i := 0; i < len(bidResponse.Bids); i++ { loop.

@curlyblueeagle
Copy link
Contributor Author

@SyntaxNode Thanks!

We did an end-to-end test and all looks well. So I am going to close this issue since my question was answered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants