Replace use of npmlog dependency with console.error #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No change to log message format or level
Aye, that can done later in a follow-up PR. |
vweevers
approved these changes
Jun 4, 2022
|
I've tagged this as |
|
Published in v7.1.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a possible approach to address #163
The
npmlogdependency always writes tostderrso the use ofconsole.error()is consistent with the previous behaviour.https://github.com/npm/npmlog/blob/7aefa36320a4265f2825f34db29f129f5927f41b/lib/log.js#L12
All existing log message formats and levels remain as before, which takes advantage of existing tests that cover these.
We could remove the concept of levels entirely, but that would have a slightly wider impact and I've not attempted it here.
Closes #163, closes #116.