Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update from C++14 to C++17 Standard #138

Merged
merged 3 commits into from
Nov 18, 2022
Merged

Update from C++14 to C++17 Standard #138

merged 3 commits into from
Nov 18, 2022

Conversation

kursatyurt
Copy link
Collaborator

To match with preCICE is PR updates C++ version of ASTE to C++17

@davidscn
Copy link
Member

If we want to do this, we should also upgrade the CMake requirements, in order to go with a corresponding Ubuntu baseline.

@kursatyurt
Copy link
Collaborator Author

If we want to do this, we should also upgrade the CMake requirements, in order to go with a corresponding Ubuntu baseline.

Now we are using Ubuntu 20.04 LTS. Should we need to move to 22.04 LTS?

I changed CMake and Boost to match preCICE requirements.

Copy link
Member

@davidscn davidscn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's fine. We should merge this once we released the distribution, as the upgrade in preCICE was applied after v2.5.0

@davidscn davidscn merged commit ab6fe47 into develop Nov 18, 2022
@davidscn davidscn deleted the change_to_cpp17 branch November 18, 2022 13:56
davidscn added a commit to davidscn/aste that referenced this pull request Dec 9, 2022
* Update from C++14 to C++17 Standart
* Change CMake and Boost versions

Co-authored-by: David Schneider <david.schneider@ipvs.uni-stuttgart.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants