-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change test name from test to precice-aste-test #175
Conversation
@kursatyurt could you elaborate this more in detail? Naming an executable and directory the same is usually no problem and works on my system. |
It throws an error in case insensitive file system. Cannot compile the test. More specifically ld: can't write output file to 'testing' because that path is a directory
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's rename it to test-aste
, because precice-aste...
are meant for users.
e0853d4
to
13d8753
Compare
Main changes of this PR
The test executable is called
testing
is clashes with Cmake testing directory.test
is located for Cmake itself. This PR changes the test executable toprecice-aste-test
Author's checklist
pre-commit
hook and usedpre-commit run --all
to apply all available hooks.docs/README.md
.precice/tutorials/aste-turbine
.