Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change test name from test to precice-aste-test #175

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Conversation

kursatyurt
Copy link
Collaborator

Main changes of this PR

The test executable is called testing is clashes with Cmake testing directory. test is located for Cmake itself. This PR changes the test executable to precice-aste-test

Author's checklist

  • I used the pre-commit hook and used pre-commit run --all to apply all available hooks.
  • I added a test to cover the proposed changes in our test suite.
  • I updated the documentation in docs/README.md.
  • I updated potential breaking changes in the tutorial precice/tutorials/aste-turbine.

@davidscn
Copy link
Member

The test executable is called testing is clashes with Cmake testing directory.

@kursatyurt could you elaborate this more in detail? Naming an executable and directory the same is usually no problem and works on my system.

@kursatyurt
Copy link
Collaborator Author

kursatyurt commented Mar 27, 2023

The test executable is called testing is clashes with Cmake testing directory.

@kursatyurt could you elaborate this more in detail? Naming an executable and directory the same is usually no problem and works on my system.

It throws an error in case insensitive file system. Cannot compile the test.

More specifically

ld: can't write output file to 'testing' because that path is a directory
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

Copy link
Member

@davidscn davidscn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rename it to test-aste, because precice-aste... are meant for users.

CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
@davidscn davidscn merged commit 3168b0e into develop Mar 21, 2024
1 check failed
@davidscn davidscn deleted the fix_name_of_test branch March 21, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants