-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache VTK build in ASTE CI #211
Conversation
I am not in favor of merging this change: In the current CI, we simply build VTK inside the preCICE nightly image. This is at the moment only a temporary workaround for the broken ubuntu packages and will most likely be resolved with a future ubuntu version (24.10 is at least known to work). Certainly, building VTK in each PR takes time (about 45mins or so). However, merging this or not is mostly a question of how much development is at the moment being pursued: with these changes, we would build VTK every day and push an image. New PRs are at the moment far below (maybe two per month). Merging here is wasteful in my opinion. What we could consider is triggering an image update not every night, but by a PR or so. |
It is wasteful for sure. Given that the base image doesn't change, we could maybe get away with caching the installed VTK files using a long TTL. At best, this can be done whilst installing to |
I don't know how such a caching would look like. We could also store the VTK install in a separate image and the use docker compose. The result should be somewhat similar to a caching mechanism. |
According to the GitHub docs
Meaning we can keep a cache alive on develop and use it in PRs. I'll try this here |
I think that's now pretty much the ideal solution. If you push now a dummy commit, the VTK build show not be triggered, correct? |
Triggered and reused the cache. |
Ok I'll squash and merge this to make debugging the other PRs quicker. |
Main changes of this PR
This PR uses the new ASTE CI image https://hub.docker.com/r/precice/ci-aste which is based on
precice/precice:nightly
and installs a working version of VTK from source.https://github.com/precice/ci-images/blob/master/ci-aste.dockerfile
TODO
keep orclean ci-imageAuthor's checklist
pre-commit
hook and usedpre-commit run --all
to apply all available hooks.docs/README.md
../changelog-entries/
(create if necessary).precice/tutorials/aste-turbine
.