Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superfluous quotes in lockfile #247

Closed
jonashaag opened this issue Aug 2, 2023 · 2 comments · Fixed by conda/rattler#277
Closed

Superfluous quotes in lockfile #247

jonashaag opened this issue Aug 2, 2023 · 2 comments · Fixed by conda/rattler#277

Comments

@jonashaag
Copy link

metadata:
  content_hash:
    osx-arm64: '"e90c2ee71ad70fc0a1c8302029533a7d1498f2bffcd0eaa8d2934700e775dc1d"'

Generated with Pixi 0.0.8

@pavelzw
Copy link
Contributor

pavelzw commented Aug 2, 2023

It may also make sense to add a version to the lockfile similar to how pnpm does it. https://github.com/mamba-org/setup-micromamba/blob/2ee1938ba9ff3b184b94f8bdd4a0b0cd9976bbe9/pnpm-lock.yaml#L1
NPM does it as well in their package-lock.json https://github.com/puppeteer/puppeteer/blob/9a814a365644a1e404eb36266a08f579bb2c26ac/package-lock.json#L3

@baszalmstra
Copy link
Contributor

Thanks @jonashaag ! I fixed the issue in rattler. Should be included in the next release of pixi.

@pavelzw We implemented the conda-lock file format which also doesn't include a version.

This is a bit off-topic but pixi also doesn't use the content-hash at all, there are better ways to solve the problems the content-hash was meant to solve. It is also already possible with the current format. That is what we are using in pixi.
We propose removing the field altogether, see conda/conda-lock#432.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants