Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I don't think it unzips .zip files #316

Closed
codegod100 opened this issue Nov 17, 2023 · 3 comments · Fixed by #425
Closed

I don't think it unzips .zip files #316

codegod100 opened this issue Nov 17, 2023 · 3 comments · Fixed by #425
Assignees

Comments

@codegod100
Copy link

When I point it at .tar.gz it unzips them into work folder, but with .zip files not so much 🤷

@swarnimarun
Copy link
Contributor

Yep iirc we don't implement extract for zip files, will take a look. Seems simple enough to resolve, will drop an update after some looking into it.

@pavelzw
Copy link
Collaborator

pavelzw commented Dec 16, 2023

Any progress on this? It currently doesn't even put the unextracted file in the work directory.

@swarnimarun
Copy link
Contributor

aah thanks I think forgot about this, opened a PR should be fixed for now.

Also note: @pavelzw we never copy unextracted files to work dir. They always remain in the cache_dir(src_cache in this case). (It's a unified directory separate from work dirs and etc.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants