Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os.remove is not documented in wiki #1543

Closed
KyrietS opened this issue Oct 25, 2020 · 5 comments
Closed

os.remove is not documented in wiki #1543

KyrietS opened this issue Oct 25, 2020 · 5 comments
Assignees
Labels

Comments

@KyrietS
Copy link
Member

KyrietS commented Oct 25, 2020

What seems to be the problem?
os.remove is missing in wiki but it's implemented: https://github.com/premake/premake-core/blob/master/src/base/os.lua#L479

What did you expect to happen?
Add it to wiki because it is the only non-source-code documentation of Premake5 at this moment. Unfortunately contributors can't make Pull Requests to wiki pages.

Anything else we should know?
os.matchfiles seems to be very similar in use so you can just copy&paste it with some minor changes. Here: https://github.com/premake/premake-core/wiki/os.matchfiles

@KyrietS KyrietS added the bug label Oct 25, 2020
@redorav
Copy link
Collaborator

redorav commented Oct 27, 2020

Interesting. I used to be able to edit the wiki freely, now I cannot. I wonder what has changed

@samsinsane
Copy link
Member

I wonder what has changed

A couple of clowns were editing it talking trash about each other, eventually leaving the footer with a link to CMake. The option was leave the wiki open to these kinds of problems, or lock it down and move towards having the docs in the repo instead. The docs weren't being updated that often anyway, so we opted to lock it down. It's unfortunate that GitHub only has two options here, any kind of approval system would be significantly better.

@KyrietS
Copy link
Member Author

KyrietS commented Oct 28, 2020

Are there any decisions made towards having the docs in the repo? There are many great frameworks for docs that work with GitHub static pages pretty well, eg.

@starkos
Copy link
Member

starkos commented Oct 28, 2020

@KyrietS No decisions made, but high on the priority list so any assistance would be very much appreciated! I've opened #1547 to get the documentation sorted.

@starkos
Copy link
Member

starkos commented Oct 28, 2020

Fixed, see os.remove.

@starkos starkos closed this as completed Oct 28, 2020
@starkos starkos self-assigned this Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants