Skip to content

Latest commit

 

History

History
58 lines (32 loc) · 3.38 KB

CONTRIBUTING.md

File metadata and controls

58 lines (32 loc) · 3.38 KB
Raw

CONTRIBUTING

These contributing guidelines were accepted rather late in the history of this plugin, after much code had already been written.

If you find any existing behavior which does not conform to these guidelines, please correct it and send a pull request.

General Rules

Every non local identifier must start with g:vim_markdown_.

Documentation

Every new feature must be documented under in the README.md. Documentation must be written in GFM since GitHub itself is the primary to HTML converter used. In particular, remember that GFM adds line breaks at single newlines, so just forget about the 70 characters wide rule.

Vim help file doc/vim-markdown.txt will be generated from README.md by make doc using vim-tools.

Markdown Flavors

There are many flavors of markdown, each one with an unique feature set. This plugin uses the following strategy to deal with all those flavors:

  • Features from the original markdown are turned on by default. They may not even have an option that turns them off.

  • Features from other markdown flavors must have an option that turns them on or off. If the feature is common enough across multiple versions of markdown, it may be turned on by default. This shall be decided by the community when the merge request is done.

  • If possible, cite the exact point in the documentation of the flavor where a feature is specified. If the feature is not documented, you may also reference the source code itself of the implementation. This way, people who do not know that flavor can check if your implementation is correct.

  • Do not use the name of a flavor for a feature that is used across multiple flavors. Instead, create a separate flavor option, that automatically sets each feature.

    For example, fenced code blocks (putting code between pairs of three backticks) is not part of the original markdown, but is supported by GFM and Jekyll.

    Therefore, instead of creating an option g:vim_markdown_gfm_fenced_code_block, and an option g:vim_markdown_jekyll_fenced_code_block, create a single option g:vim_markdown_fenced_code_block.

    Next, if there are many more than one Jekyll feature options, create a g:vim_markdown_jekyll option that turns them all on at once.

Style

When choosing between multiple valid Markdown syntaxes, the default behavior must be that specified at: https://cirosantilli.com/markdown-style-guide

If you wish to have a behavior that differs from that style guide, add an option to turn it on or off, and leave it off by default.

Tests

All new features must have unit tests.

Issues

Issues are tracked within GitHub.

When reporting issues, your report is more effective if you include a minimal example file that reproduces the problem. Try to trim out as much as possible, until you have the smallest possible file that still reproduces the issue. Paste the example inline into your issue report, quoted using four spaces at the beginning of each line, like this example from issue #189:

Minimal example:

    ```
    =
    ```
    bad!