Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to python3 [$20] #199

Closed
vtemian opened this issue Aug 26, 2015 · 7 comments
Closed

Port to python3 [$20] #199

vtemian opened this issue Aug 26, 2015 · 7 comments
Labels

Comments

@vtemian
Copy link
Contributor

vtemian commented Aug 26, 2015

Gitfs was written using only Python 2 code, but now, as the things in Python 3 evolves and are very stable, we need to port our Python 2 code to Python 3 compatible code.

Did you help close this issue? Go claim the $20 bounty on Bountysource.

@vtemian vtemian changed the title Port to python3 Port to python3 [$20] Aug 26, 2015
@vtemian vtemian added the bounty label Aug 26, 2015
@cdvv7788
Copy link

cdvv7788 commented Sep 3, 2015

This will probably rise some issues after the update for things not covered in the tests. I will give it a go this week. It should be both 2.7 and 3.4 compatible, right?

@goranpavlovic
Copy link

I will work on this in this week. Can you have any suggestions for me? Thanks
For now i found some compatibility issues with octal numbers which is used for permissions.
I also found another compatibility issues such as urlparse and Queue, and solved that.

@vtemian
Copy link
Contributor Author

vtemian commented Oct 28, 2015

Hi guys,

@cdvv7788 yep, 3.4 sounds great.
@goranpavlovic you can find some tools and articles online:

@goranpavlovic
Copy link

I have solved some of problems.

  1. Compatiblity issue with python basestiring function, python3 does not have defined this function.
  2. Compatibility issue with timestamp.
  3. Compatibility issue with iteritems function.
  4. Issues with different way to use octal numbers in python2 and python3 which you use for permissions.
  5. Different way for using urllib functionality.
  6. Issue with queue class in python versions 2 and 3.

After that changes
I have installed application normally to python3 virtual environment.
Also application is successfully started.

But i just have one problem for now , when i go to directory which is mounted using gitfs
and on index route try to get list of files with command ls or ls -als
i get this error:
ls: reading directory .: Function not implemented
total 0

But in index view and in python2.7 environment i see that output should be ['.', '..', 'current', 'history']

Function readdir is not called.

I assume that i have compatibility issue with some interfaces or classes such as
some method name was changed or something like that.

I will continue work on this problem.

I forgot to say this, i am working with python 3.4

Thanks

@justuswilhelm
Copy link
Contributor

Hi, I've created a solution with #212, it includes working tests both on drone and vagrant.

@justuswilhelm
Copy link
Contributor

@vtemian Can the issue be closed?

@vtemian
Copy link
Contributor Author

vtemian commented Nov 21, 2015

Yep

@vtemian vtemian closed this as completed Nov 21, 2015
@vtemian vtemian removed the could label Nov 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants