Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Support: Checkstyle #2342

Closed
kadaan opened this issue Feb 9, 2015 · 4 comments
Closed

Windows Support: Checkstyle #2342

kadaan opened this issue Feb 9, 2015 · 4 comments

Comments

@kadaan
Copy link

kadaan commented Feb 9, 2015

Presto fails to build on Windows due to checkstyle enforcing that lines end in \n. This is not the line separator in windows. Can the checkstyle checks be changed to allow any of: \r\n, \n, \r? Alternately, can a .gitattributes file be added which specifies that LF is the correct newline character by: text eol=lf

@ArturGajowy
Copy link
Contributor

I think the latter (.gitattributes) would be a better solution. @electrum WDYT?

@findepi
Copy link
Contributor

findepi commented Jun 6, 2017

@kadaan, the repository doesn't contain source files with \r\n. If your git client creates such line endings upon checkout, it's a matter of your git client's configuration. Did you set core.autocrlf?

@blackhawkbigpunch
Copy link

Setting core.autocrlf to false bypassed the fail with maven-checkstyle-plugin issue in windows.

@findepi
Copy link
Contributor

findepi commented May 2, 2018

@blackhawkbigpunch thanks for sharing this

@findepi findepi closed this as completed May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants