-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add carriage return "\r" to showInvisibles #99
Comments
I suppose another option would be to use ⏎ for both Another option would be to use the literal text |
"Replace ⏎ with ⏎ " is a confusing and I'd like to avoid it. Literal How about ␍ (see https://en.wiktionary.org/wiki/%E2%90%8D) |
Sounds good to me. Would you be interested in creating a PR? |
There you go ^^ |
Prettier will format files using the first line-ending it sees. This means that files that use
\r\n as line breaks will keep them.
showInvisibles has conversions for space, \n and \t. It'd be good if it had a replacement for \r as well so report output doesn't look goofy for crlf files as the terminal tries to render the literal carriage return.
Unfortunately I'm not sure what the best solution for this is. There's no character that screams "I'm a carriage return" that I'm aware of. Perhaps ⏎ can be used for \n (as it is now), and a slightly different character can be used for a \r\n combo?
I reckon we can ignore files with just \r line endings (macos 9 lols)
The text was updated successfully, but these errors were encountered: