Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baseicon: Content Security Policy (CSP) violation #4271

Closed
ydcjeff opened this issue Aug 14, 2023 · 0 comments
Closed

Baseicon: Content Security Policy (CSP) violation #4271

ydcjeff opened this issue Aug 14, 2023 · 0 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@ydcjeff
Copy link

ydcjeff commented Aug 14, 2023

Describe the bug

Hello, Thanks for working on Content Security Policy (CSP) config (#4241) feature. It was added in PrimeVue 3.32.0. I upgraded 3.32.0 and CSP config is working as intended except at one place – Baseicon.

In the built baseicon file, the icon styles are added with styleInject helper which I think comes from package building.

https://unpkg.com/browse/primevue@3.32.0/baseicon/baseicon.esm.js

Reproducer

https://stackblitz.com/edit/vitejs-vite-sd5fap?file=dist%2Fassets%2Findex-40ac3a51.js

PrimeVue version

3.32.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

  1. npm i
  2. npm run build
  3. Search Baseicon in the built file, and scroll down a bit to see the styleInject function.

Expected behavior

styleInject helper function to respect PrimeVue CSP config.

@ydcjeff ydcjeff added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 14, 2023
@mertsincan mertsincan self-assigned this Aug 17, 2023
@mertsincan mertsincan added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 17, 2023
@mertsincan mertsincan added this to the 3.32.1 milestone Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

2 participants