Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BaseIcon: p-icon and p-icon-spin classes in unstyled mode #4692

Closed
strobh opened this issue Oct 25, 2023 · 0 comments
Closed

BaseIcon: p-icon and p-icon-spin classes in unstyled mode #4692

strobh opened this issue Oct 25, 2023 · 0 comments
Assignees
@mertsincan
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
3.45.0

Comments

@strobh
Copy link

strobh commented Oct 25, 2023

Describe the bug

The <svg> element of the BaseIcon component has the CSS classes p-icon and p-icon-spin, even though PrimeVue is used in unstyled mode. As far as I can see, the CSS classes are specified here (BaseIcon.vue) regardless of whether the unstyled mode is enabled or not.

Reproducer

https://codesandbox.io/p/sandbox/unruffled-chihiro-9yx5y3?file=%2Fsrc%2FApp.vue%3A21%2C9-21%2C26

PrimeVue version

3.37.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

I noticed this bug in the loading overlay of the DataTable component as can be seen in the reproducer above. I had accidentally defined a style for .p-icon globally which had an effect on the loading icon.

Expected behavior

The BaseIcon should not have the classes p-icon and p-icon-spin in unstyled mode.
@strobh strobh added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 25, 2023
@strobh strobh changed the title BaseIcon: p-icon and p-icon-spin class in unstyled mode BaseIcon: p-icon and p-icon-spin classes in unstyled mode Oct 25, 2023
@mertsincan mertsincan added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 20, 2023
@mertsincan mertsincan added this to the 3.45.0 milestone Dec 20, 2023
@mertsincan mertsincan self-assigned this Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mertsincan mertsincan

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
3.45.0
Development

No branches or pull requests
2 participants
@strobh @mertsincan