Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook for Primer CSS #1660

Closed
langermank opened this issue Oct 7, 2021 · 0 comments · Fixed by #1678
Closed

Storybook for Primer CSS #1660

langermank opened this issue Oct 7, 2021 · 0 comments · Fixed by #1678

Comments

@langermank
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Outside of developing directly in the docs site, I didn't see a clear path towards building new CSS only components for Primer. I've seen some folks use codepen or a custom repo, but having a stable "playground" that comes with all the dependencies you need to contribute would be nice.

Describe the solution you'd like
Storybook is an out of the box solution that other Primer implementations are using (React and View Components). It's also somewhat universally understood, so onboarding new designers/developers could arguably be easier.

Describe alternatives you've considered
Storybook is the only tool I explored as I'm most familiar with it, and it was quick to configure.

Additional context

  • Primer CSS already contains React in the /docs directory for the Gatsby site
  • Writing stories as we build new CSS components allows us to work with conditional logic, leading to more robust solutions that handle edge cases
  • Writing stories with conditionals brings us one step closer to View Components (logic has been worked out, just needs to be hooked up)

Configuration is in the ActionList CSS PR, but I'll likely move it to its own PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant