From 08224d6a299eb8e934a22342f928a846843a3a37 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 18 Sep 2024 10:49:07 -0500 Subject: [PATCH 001/151] chore(deps-dev): bump vite from 5.2.6 to 5.2.14 (#4984) Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.2.6 to 5.2.14. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v5.2.14/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v5.2.14/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: direct:development ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- examples/codesandbox/package.json | 2 +- package-lock.json | 19 ++++++++++--------- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/examples/codesandbox/package.json b/examples/codesandbox/package.json index 9fb3fa39458..76012d3e491 100644 --- a/examples/codesandbox/package.json +++ b/examples/codesandbox/package.json @@ -26,6 +26,6 @@ "eslint-plugin-react-refresh": "^0.4.7", "styled-components": "5.x", "typescript": "^5.4.5", - "vite": "^5.2.6" + "vite": "^5.2.14" } } diff --git a/package-lock.json b/package-lock.json index 8ff1ee97022..610cf18be22 100644 --- a/package-lock.json +++ b/package-lock.json @@ -64,7 +64,7 @@ "name": "example-app-router", "version": "0.0.0", "dependencies": { - "@primer/react": "37.0.0-rc.4", + "@primer/react": "37.0.0-rc.5", "next": "^14.2.8", "react": "^18.3.1", "react-dom": "^18.3.1", @@ -83,7 +83,7 @@ "react-dom": "^18.3.1" }, "devDependencies": { - "@primer/react": "37.0.0-rc.4", + "@primer/react": "37.0.0-rc.5", "@types/react": "^18.3.3", "@types/react-dom": "^18.3.0", "@typescript-eslint/eslint-plugin": "^7.11.0", @@ -94,14 +94,14 @@ "eslint-plugin-react-refresh": "^0.4.7", "styled-components": "5.x", "typescript": "^5.4.5", - "vite": "^5.2.6" + "vite": "^5.2.14" } }, "examples/consumer-test": { "name": "example-consumer-test", "version": "0.0.0", "dependencies": { - "@primer/react": "37.0.0-rc.4", + "@primer/react": "37.0.0-rc.5", "@types/react": "^18.2.14", "@types/react-dom": "^18.2.19", "@types/styled-components": "^5.1.11", @@ -127,7 +127,7 @@ "version": "0.0.0", "dependencies": { "@primer/octicons-react": "^19.9.0", - "@primer/react": "37.0.0-rc.4", + "@primer/react": "37.0.0-rc.5", "clsx": "^1.2.1", "next": "^14.2.8", "react": "^18.3.1", @@ -30081,12 +30081,13 @@ "license": "MIT" }, "node_modules/vite": { - "version": "5.2.6", + "version": "5.2.14", + "resolved": "https://registry.npmjs.org/vite/-/vite-5.2.14.tgz", + "integrity": "sha512-TFQLuwWLPms+NBNlh0D9LZQ+HXW471COABxw/9TEUBrjuHMo9BrYBPrN/SYAwIuVL+rLerycxiLT41t4f5MZpA==", "dev": true, - "license": "MIT", "dependencies": { "esbuild": "^0.20.1", - "postcss": "^8.4.36", + "postcss": "^8.4.38", "rollup": "^4.13.0" }, "bin": { @@ -31105,7 +31106,7 @@ }, "packages/react": { "name": "@primer/react", - "version": "37.0.0-rc.4", + "version": "37.0.0-rc.5", "license": "MIT", "dependencies": { "@github/relative-time-element": "^4.4.2", From 3c39717ed5e8e8388f7130d2baf7360b6a8adf96 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 18 Sep 2024 11:14:59 -0500 Subject: [PATCH 002/151] chore(deps): bump next from 14.2.8 to 14.2.10 (#4985) Bumps [next](https://github.com/vercel/next.js) from 14.2.8 to 14.2.10. - [Release notes](https://github.com/vercel/next.js/releases) - [Changelog](https://github.com/vercel/next.js/blob/canary/release.js) - [Commits](https://github.com/vercel/next.js/compare/v14.2.8...v14.2.10) --- updated-dependencies: - dependency-name: next dependency-type: direct:production ... Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --- examples/app-router/package.json | 2 +- examples/theming/package.json | 2 +- package-lock.json | 87 +++++++++++++++++--------------- 3 files changed, 47 insertions(+), 44 deletions(-) diff --git a/examples/app-router/package.json b/examples/app-router/package.json index 52b1e46d250..e0628d3d997 100644 --- a/examples/app-router/package.json +++ b/examples/app-router/package.json @@ -11,7 +11,7 @@ }, "dependencies": { "@primer/react": "37.0.0-rc.5", - "next": "^14.2.8", + "next": "^14.2.10", "react": "^18.3.1", "react-dom": "^18.3.1", "styled-components": "5.x", diff --git a/examples/theming/package.json b/examples/theming/package.json index 3daca81ba49..b75ebc79b92 100644 --- a/examples/theming/package.json +++ b/examples/theming/package.json @@ -13,7 +13,7 @@ "@primer/octicons-react": "^19.9.0", "@primer/react": "37.0.0-rc.5", "clsx": "^1.2.1", - "next": "^14.2.8", + "next": "^14.2.10", "react": "^18.3.1", "react-dom": "^18.3.1", "styled-components": "5.x", diff --git a/package-lock.json b/package-lock.json index 610cf18be22..88ab3783fe7 100644 --- a/package-lock.json +++ b/package-lock.json @@ -65,7 +65,7 @@ "version": "0.0.0", "dependencies": { "@primer/react": "37.0.0-rc.5", - "next": "^14.2.8", + "next": "^14.2.10", "react": "^18.3.1", "react-dom": "^18.3.1", "styled-components": "5.x", @@ -129,7 +129,7 @@ "@primer/octicons-react": "^19.9.0", "@primer/react": "37.0.0-rc.5", "clsx": "^1.2.1", - "next": "^14.2.8", + "next": "^14.2.10", "react": "^18.3.1", "react-dom": "^18.3.1", "styled-components": "5.x", @@ -5775,8 +5775,9 @@ } }, "node_modules/@next/env": { - "version": "14.2.8", - "license": "MIT" + "version": "14.2.10", + "resolved": "https://registry.npmjs.org/@next/env/-/env-14.2.10.tgz", + "integrity": "sha512-dZIu93Bf5LUtluBXIv4woQw2cZVZ2DJTjax5/5DOs3lzEOeKLy7GxRSr4caK9/SCPdaW6bCgpye6+n4Dh9oJPw==" }, "node_modules/@next/eslint-plugin-next": { "version": "14.1.0", @@ -5830,11 +5831,12 @@ } }, "node_modules/@next/swc-darwin-arm64": { - "version": "14.2.8", + "version": "14.2.10", + "resolved": "https://registry.npmjs.org/@next/swc-darwin-arm64/-/swc-darwin-arm64-14.2.10.tgz", + "integrity": "sha512-V3z10NV+cvMAfxQUMhKgfQnPbjw+Ew3cnr64b0lr8MDiBJs3eLnM6RpGC46nhfMZsiXgQngCJKWGTC/yDcgrDQ==", "cpu": [ "arm64" ], - "license": "MIT", "optional": true, "os": [ "darwin" @@ -5844,9 +5846,9 @@ } }, "node_modules/@next/swc-darwin-x64": { - "version": "14.2.8", - "resolved": "https://registry.npmjs.org/@next/swc-darwin-x64/-/swc-darwin-x64-14.2.8.tgz", - "integrity": "sha512-87t3I86rNRSOJB1gXIUzaQWWSWrkWPDyZGsR0Z7JAPtLeX3uUOW2fHxl7dNWD2BZvbvftctTQjgtfpp7nMtmWg==", + "version": "14.2.10", + "resolved": "https://registry.npmjs.org/@next/swc-darwin-x64/-/swc-darwin-x64-14.2.10.tgz", + "integrity": "sha512-Y0TC+FXbFUQ2MQgimJ/7Ina2mXIKhE7F+GUe1SgnzRmwFY3hX2z8nyVCxE82I2RicspdkZnSWMn4oTjIKz4uzA==", "cpu": [ "x64" ], @@ -5859,9 +5861,9 @@ } }, "node_modules/@next/swc-linux-arm64-gnu": { - "version": "14.2.8", - "resolved": "https://registry.npmjs.org/@next/swc-linux-arm64-gnu/-/swc-linux-arm64-gnu-14.2.8.tgz", - "integrity": "sha512-ta2sfVzbOpTbgBrF9HM5m+U58dv6QPuwU4n5EX4LLyCJGKc433Z0D9h9gay/HSOjLEXJ2fJYrMP5JYYbHdxhtw==", + "version": "14.2.10", + "resolved": "https://registry.npmjs.org/@next/swc-linux-arm64-gnu/-/swc-linux-arm64-gnu-14.2.10.tgz", + "integrity": "sha512-ZfQ7yOy5zyskSj9rFpa0Yd7gkrBnJTkYVSya95hX3zeBG9E55Z6OTNPn1j2BTFWvOVVj65C3T+qsjOyVI9DQpA==", "cpu": [ "arm64" ], @@ -5874,9 +5876,9 @@ } }, "node_modules/@next/swc-linux-arm64-musl": { - "version": "14.2.8", - "resolved": "https://registry.npmjs.org/@next/swc-linux-arm64-musl/-/swc-linux-arm64-musl-14.2.8.tgz", - "integrity": "sha512-+IoLTPK6Z5uIgDhgeWnQF5/o5GBN7+zyUNrs4Bes1W3g9++YELb8y0unFybS8s87ntAKMDl6jeQ+mD7oNwp/Ng==", + "version": "14.2.10", + "resolved": "https://registry.npmjs.org/@next/swc-linux-arm64-musl/-/swc-linux-arm64-musl-14.2.10.tgz", + "integrity": "sha512-n2i5o3y2jpBfXFRxDREr342BGIQCJbdAUi/K4q6Env3aSx8erM9VuKXHw5KNROK9ejFSPf0LhoSkU/ZiNdacpQ==", "cpu": [ "arm64" ], @@ -5889,9 +5891,9 @@ } }, "node_modules/@next/swc-linux-x64-gnu": { - "version": "14.2.8", - "resolved": "https://registry.npmjs.org/@next/swc-linux-x64-gnu/-/swc-linux-x64-gnu-14.2.8.tgz", - "integrity": "sha512-pO+hVXC+mvzUOQJJRG4RX4wJsRJ5BkURSf6dD6EjUXAX4Ml9es1WsEfkaZ4lcpmFzFvY47IkDaffks/GdCn9ag==", + "version": "14.2.10", + "resolved": "https://registry.npmjs.org/@next/swc-linux-x64-gnu/-/swc-linux-x64-gnu-14.2.10.tgz", + "integrity": "sha512-GXvajAWh2woTT0GKEDlkVhFNxhJS/XdDmrVHrPOA83pLzlGPQnixqxD8u3bBB9oATBKB//5e4vpACnx5Vaxdqg==", "cpu": [ "x64" ], @@ -5904,9 +5906,9 @@ } }, "node_modules/@next/swc-linux-x64-musl": { - "version": "14.2.8", - "resolved": "https://registry.npmjs.org/@next/swc-linux-x64-musl/-/swc-linux-x64-musl-14.2.8.tgz", - "integrity": "sha512-bCat9izctychCtf3uL1nqHq31N5e1VxvdyNcBQflkudPMLbxVnlrw45Vi87K+lt1CwrtVayHqzo4ie0Szcpwzg==", + "version": "14.2.10", + "resolved": "https://registry.npmjs.org/@next/swc-linux-x64-musl/-/swc-linux-x64-musl-14.2.10.tgz", + "integrity": "sha512-opFFN5B0SnO+HTz4Wq4HaylXGFV+iHrVxd3YvREUX9K+xfc4ePbRrxqOuPOFjtSuiVouwe6uLeDtabjEIbkmDA==", "cpu": [ "x64" ], @@ -5919,9 +5921,9 @@ } }, "node_modules/@next/swc-win32-arm64-msvc": { - "version": "14.2.8", - "resolved": "https://registry.npmjs.org/@next/swc-win32-arm64-msvc/-/swc-win32-arm64-msvc-14.2.8.tgz", - "integrity": "sha512-gbxfUaSPV7EyUobpavida2Hwi62GhSJaSg7iBjmBWoxkxlmETOD7U4tWt763cGIsyE6jM7IoNavq0BXqwdW2QA==", + "version": "14.2.10", + "resolved": "https://registry.npmjs.org/@next/swc-win32-arm64-msvc/-/swc-win32-arm64-msvc-14.2.10.tgz", + "integrity": "sha512-9NUzZuR8WiXTvv+EiU/MXdcQ1XUvFixbLIMNQiVHuzs7ZIFrJDLJDaOF1KaqttoTujpcxljM/RNAOmw1GhPPQQ==", "cpu": [ "arm64" ], @@ -5934,9 +5936,9 @@ } }, "node_modules/@next/swc-win32-ia32-msvc": { - "version": "14.2.8", - "resolved": "https://registry.npmjs.org/@next/swc-win32-ia32-msvc/-/swc-win32-ia32-msvc-14.2.8.tgz", - "integrity": "sha512-PUXzEzjTTlUh3b5VAn1nlpwvujTnuCMMwbiCnaTazoVlN1nA3kWjlmp42IfURA2N/nyrlVEw7pURa/o4Qxj1cw==", + "version": "14.2.10", + "resolved": "https://registry.npmjs.org/@next/swc-win32-ia32-msvc/-/swc-win32-ia32-msvc-14.2.10.tgz", + "integrity": "sha512-fr3aEbSd1GeW3YUMBkWAu4hcdjZ6g4NBl1uku4gAn661tcxd1bHs1THWYzdsbTRLcCKLjrDZlNp6j2HTfrw+Bg==", "cpu": [ "ia32" ], @@ -5949,9 +5951,9 @@ } }, "node_modules/@next/swc-win32-x64-msvc": { - "version": "14.2.8", - "resolved": "https://registry.npmjs.org/@next/swc-win32-x64-msvc/-/swc-win32-x64-msvc-14.2.8.tgz", - "integrity": "sha512-EnPKv0ttq02E9/1KZ/8Dn7kuutv6hy1CKc0HlNcvzOQcm4/SQtvfws5gY0zrG9tuupd3HfC2L/zcTrnBhpjTuQ==", + "version": "14.2.10", + "resolved": "https://registry.npmjs.org/@next/swc-win32-x64-msvc/-/swc-win32-x64-msvc-14.2.10.tgz", + "integrity": "sha512-UjeVoRGKNL2zfbcQ6fscmgjBAS/inHBh63mjIlfPg/NG8Yn2ztqylXt5qilYb6hoHIwaU2ogHknHWWmahJjgZQ==", "cpu": [ "x64" ], @@ -21759,10 +21761,11 @@ } }, "node_modules/next": { - "version": "14.2.8", - "license": "MIT", + "version": "14.2.10", + "resolved": "https://registry.npmjs.org/next/-/next-14.2.10.tgz", + "integrity": "sha512-sDDExXnh33cY3RkS9JuFEKaS4HmlWmDKP1VJioucCG6z5KuA008DPsDZOzi8UfqEk3Ii+2NCQSJrfbEWtZZfww==", "dependencies": { - "@next/env": "14.2.8", + "@next/env": "14.2.10", "@swc/helpers": "0.5.5", "busboy": "1.6.0", "caniuse-lite": "^1.0.30001579", @@ -21777,15 +21780,15 @@ "node": ">=18.17.0" }, "optionalDependencies": { - "@next/swc-darwin-arm64": "14.2.8", - "@next/swc-darwin-x64": "14.2.8", - "@next/swc-linux-arm64-gnu": "14.2.8", - "@next/swc-linux-arm64-musl": "14.2.8", - "@next/swc-linux-x64-gnu": "14.2.8", - "@next/swc-linux-x64-musl": "14.2.8", - "@next/swc-win32-arm64-msvc": "14.2.8", - "@next/swc-win32-ia32-msvc": "14.2.8", - "@next/swc-win32-x64-msvc": "14.2.8" + "@next/swc-darwin-arm64": "14.2.10", + "@next/swc-darwin-x64": "14.2.10", + "@next/swc-linux-arm64-gnu": "14.2.10", + "@next/swc-linux-arm64-musl": "14.2.10", + "@next/swc-linux-x64-gnu": "14.2.10", + "@next/swc-linux-x64-musl": "14.2.10", + "@next/swc-win32-arm64-msvc": "14.2.10", + "@next/swc-win32-ia32-msvc": "14.2.10", + "@next/swc-win32-x64-msvc": "14.2.10" }, "peerDependencies": { "@opentelemetry/api": "^1.1.0", From 0b89fc040e05a61de4a686d3054f4cb6d9f32f6d Mon Sep 17 00:00:00 2001 From: Jon Rohan Date: Wed, 18 Sep 2024 09:15:21 -0700 Subject: [PATCH 003/151] Change the Link component feature flag from primer_react_css_modules_staff to primer_react_css_modules_ga (#4975) * Move Link to ga feature flag * Create dirty-pianos-wash.md --- .changeset/dirty-pianos-wash.md | 5 +++++ e2e/components/Link.test.ts | 4 ++-- packages/react/src/Link/Link.tsx | 2 +- 3 files changed, 8 insertions(+), 3 deletions(-) create mode 100644 .changeset/dirty-pianos-wash.md diff --git a/.changeset/dirty-pianos-wash.md b/.changeset/dirty-pianos-wash.md new file mode 100644 index 00000000000..5366b730c69 --- /dev/null +++ b/.changeset/dirty-pianos-wash.md @@ -0,0 +1,5 @@ +--- +"@primer/react": patch +--- + +Change the Link component feature flag from primer_react_css_modules_staff to primer_react_css_modules_ga diff --git a/e2e/components/Link.test.ts b/e2e/components/Link.test.ts index 13c6a8ab906..19a1b60d470 100644 --- a/e2e/components/Link.test.ts +++ b/e2e/components/Link.test.ts @@ -32,7 +32,7 @@ test.describe('Link', () => { globals: { colorScheme: theme, featureFlags: { - primer_react_css_modules_staff: true, + primer_react_css_modules_ga: true, }, }, }) @@ -55,7 +55,7 @@ test.describe('Link', () => { globals: { colorScheme: theme, featureFlags: { - primer_react_css_modules_staff: true, + primer_react_css_modules_ga: true, }, }, }) diff --git a/packages/react/src/Link/Link.tsx b/packages/react/src/Link/Link.tsx index 33d0562e477..608ca582edf 100644 --- a/packages/react/src/Link/Link.tsx +++ b/packages/react/src/Link/Link.tsx @@ -62,7 +62,7 @@ const StyledLink = styled.a` ` const Link = forwardRef(({as: Component = 'a', className, inline, underline, ...props}, forwardedRef) => { - const enabled = useFeatureFlag('primer_react_css_modules_staff') + const enabled = useFeatureFlag('primer_react_css_modules_ga') const innerRef = React.useRef(null) useRefObjectAsForwardedRef(forwardedRef, innerRef) From 44a3dc94f38e8056200155ea19bfd19904d8cba2 Mon Sep 17 00:00:00 2001 From: Josh Black Date: Wed, 18 Sep 2024 11:33:42 -0500 Subject: [PATCH 004/151] fix(UnderlinePanels): add explicit type="button" to UnderlinePanels (#4970) * refactor(eslint): enable react/button-has-type rule * fix(UnderlinePanels): add explicit type="button" to UnderlinePanels * chore: add changeset * chore: fix eslint violation --------- Co-authored-by: Josh Black --- .changeset/selfish-carpets-breathe.md | 5 ++ .eslintrc.js | 1 + .../ActionList.features.stories.tsx | 6 ++- .../react/src/ActionList/ActionList.test.tsx | 4 +- .../src/TooltipV2/__tests__/Tooltip.test.tsx | 2 +- packages/react/src/TreeView/TreeView.test.tsx | 12 +++-- .../src/UnderlineNav/UnderlineNav.test.tsx | 2 +- packages/react/src/__tests__/Dialog.test.tsx | 4 +- .../__tests__/TextInputWithTokens.test.tsx | 8 ++- .../src/__tests__/ThemeProvider.test.tsx | 54 +++++++++++++++---- .../hooks/useMenuInitialFocus.test.tsx | 8 +-- .../src/__tests__/hooks/useMnemonics.test.tsx | 22 +++++--- .../hooks/useOnOutsideClick.test.tsx | 8 ++- .../hooks/useOpenAndCloseFocus.test.tsx | 18 ++++--- .../UnderlinePanels/UnderlinePanels.tsx | 1 + 15 files changed, 113 insertions(+), 42 deletions(-) create mode 100644 .changeset/selfish-carpets-breathe.md diff --git a/.changeset/selfish-carpets-breathe.md b/.changeset/selfish-carpets-breathe.md new file mode 100644 index 00000000000..b7e33098ea3 --- /dev/null +++ b/.changeset/selfish-carpets-breathe.md @@ -0,0 +1,5 @@ +--- +'@primer/react': patch +--- + +Update tab in UnderlinePanels to set explicit type diff --git a/.eslintrc.js b/.eslintrc.js index ad4b613cd44..b61b249e1dd 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -61,6 +61,7 @@ module.exports = { // rules which apply to JS, TS, etc. rules: { 'no-shadow': 'off', + 'react/button-has-type': 'error', 'react/prop-types': 'off', 'react/display-name': 'off', 'react-hooks/exhaustive-deps': 'error', diff --git a/packages/react/src/ActionList/ActionList.features.stories.tsx b/packages/react/src/ActionList/ActionList.features.stories.tsx index e2beee85f9e..c7e6c6be821 100644 --- a/packages/react/src/ActionList/ActionList.features.stories.tsx +++ b/packages/react/src/ActionList/ActionList.features.stories.tsx @@ -637,7 +637,11 @@ export const InsideOverlay = () => { open={open} onOpen={toggle} onClose={toggle} - renderAnchor={props => } + renderAnchor={props => ( + + )} > diff --git a/packages/react/src/ActionList/ActionList.test.tsx b/packages/react/src/ActionList/ActionList.test.tsx index 04a51881d26..fb847677cdc 100644 --- a/packages/react/src/ActionList/ActionList.test.tsx +++ b/packages/react/src/ActionList/ActionList.test.tsx @@ -465,7 +465,9 @@ describe('ActionList', () => { return ( - + Item 1 Item 2 diff --git a/packages/react/src/TooltipV2/__tests__/Tooltip.test.tsx b/packages/react/src/TooltipV2/__tests__/Tooltip.test.tsx index 3a237603182..0bf8c8b3149 100644 --- a/packages/react/src/TooltipV2/__tests__/Tooltip.test.tsx +++ b/packages/react/src/TooltipV2/__tests__/Tooltip.test.tsx @@ -128,7 +128,7 @@ describe('Tooltip', () => {
Legend - +
, ) diff --git a/packages/react/src/TreeView/TreeView.test.tsx b/packages/react/src/TreeView/TreeView.test.tsx index 3dc535270fa..74fd658ed85 100644 --- a/packages/react/src/TreeView/TreeView.test.tsx +++ b/packages/react/src/TreeView/TreeView.test.tsx @@ -249,7 +249,7 @@ describe('Markup', () => { const user = userEvent.setup({delay: null}) const {getByRole} = renderWithTheme(
- + Item 1 @@ -277,7 +277,7 @@ describe('Markup', () => { const user = userEvent.setup({delay: null}) const {getByRole} = renderWithTheme(
- + Item 1 @@ -318,13 +318,13 @@ describe('Markup', () => { Item 1 Item 2 - Item 3 - +
, ) @@ -1359,7 +1359,9 @@ describe('Asyncronous loading', () => { return (
{/* Mimic the completion of async loading by clicking the button */} - + Parent diff --git a/packages/react/src/UnderlineNav/UnderlineNav.test.tsx b/packages/react/src/UnderlineNav/UnderlineNav.test.tsx index bd1551a3922..5d7793390a3 100644 --- a/packages/react/src/UnderlineNav/UnderlineNav.test.tsx +++ b/packages/react/src/UnderlineNav/UnderlineNav.test.tsx @@ -67,7 +67,7 @@ const ResponsiveUnderlineNav = ({ ))} - {displayExtraEl && } + {displayExtraEl && }
) } diff --git a/packages/react/src/__tests__/Dialog.test.tsx b/packages/react/src/__tests__/Dialog.test.tsx index 281f4c5d641..0fed5ca5172 100644 --- a/packages/react/src/__tests__/Dialog.test.tsx +++ b/packages/react/src/__tests__/Dialog.test.tsx @@ -61,7 +61,7 @@ const DialogWithCustomFocusRef = () => { Title Some content - @@ -90,7 +90,7 @@ const DialogWithCustomFocusRefAndReturnFocusRef = () => { Title Some content - diff --git a/packages/react/src/__tests__/TextInputWithTokens.test.tsx b/packages/react/src/__tests__/TextInputWithTokens.test.tsx index d70ec90d97d..10a21222184 100644 --- a/packages/react/src/__tests__/TextInputWithTokens.test.tsx +++ b/packages/react/src/__tests__/TextInputWithTokens.test.tsx @@ -317,7 +317,9 @@ describe('TextInputWithTokens', () => { onTokenRemove={onRemoveMock} visibleTokenCount={visibleTokenCount} /> - + , ) const inputNode = getByLabelText('Tokens') @@ -373,7 +375,9 @@ describe('TextInputWithTokens', () => { onTokenRemove={onRemoveMock} visibleTokenCount={visibleTokenCount} /> - + , ) const inputNode = getByLabelText('Tokens') diff --git a/packages/react/src/__tests__/ThemeProvider.test.tsx b/packages/react/src/__tests__/ThemeProvider.test.tsx index c94e6d3fd72..66d79d2590c 100644 --- a/packages/react/src/__tests__/ThemeProvider.test.tsx +++ b/packages/react/src/__tests__/ThemeProvider.test.tsx @@ -203,7 +203,9 @@ it('updates when colorMode prop changes', async () => { return ( {colorMode} - + ) } @@ -229,7 +231,9 @@ it('updates when dayScheme prop changes', async () => { return ( {dayScheme} - + ) } @@ -255,7 +259,9 @@ it('updates when nightScheme prop changes', async () => { return ( {nightScheme} - + ) } @@ -280,7 +286,9 @@ it('inherits colorMode from parent', async () => { const [colorMode, setcolorMode] = React.useState<'day' | 'night'>('day') return ( - + {colorMode} @@ -304,7 +312,9 @@ it('inherits dayScheme from parent', async () => { const [dayScheme, setDayScheme] = React.useState('light') return ( - + {dayScheme} @@ -328,7 +338,9 @@ it('inherits nightScheme from parent', async () => { const [nightScheme, setNightScheme] = React.useState('dark') return ( - + {nightScheme} @@ -351,7 +363,11 @@ describe('setColorMode', () => { function ToggleMode() { const {colorMode, setColorMode} = useTheme() - return + return ( + + ) } render( @@ -377,7 +393,11 @@ describe('setDayScheme', () => { function ToggleDayScheme() { const {dayScheme, setDayScheme} = useTheme() - return + return ( + + ) } render( @@ -403,7 +423,11 @@ describe('setNightScheme', () => { function ToggleNightScheme() { const {nightScheme, setNightScheme} = useTheme() - return + return ( + + ) } render( @@ -429,7 +453,11 @@ describe('useColorSchemeVar', () => { function ToggleMode() { const {colorMode, setColorMode} = useTheme() - return + return ( + + ) } function CustomBg() { @@ -464,7 +492,11 @@ describe('useColorSchemeVar', () => { function ToggleMode() { const {colorMode, setColorMode} = useTheme() - return + return ( + + ) } function CustomBg() { diff --git a/packages/react/src/__tests__/hooks/useMenuInitialFocus.test.tsx b/packages/react/src/__tests__/hooks/useMenuInitialFocus.test.tsx index e5d5dc65ce7..7519ca1a1d5 100644 --- a/packages/react/src/__tests__/hooks/useMenuInitialFocus.test.tsx +++ b/packages/react/src/__tests__/hooks/useMenuInitialFocus.test.tsx @@ -12,15 +12,15 @@ const Component = () => { return ( <> - {open && (
not focusable - - - + + + not focusable
)} diff --git a/packages/react/src/__tests__/hooks/useMnemonics.test.tsx b/packages/react/src/__tests__/hooks/useMnemonics.test.tsx index 6b2949c7404..2070db57621 100644 --- a/packages/react/src/__tests__/hooks/useMnemonics.test.tsx +++ b/packages/react/src/__tests__/hooks/useMnemonics.test.tsx @@ -21,12 +21,22 @@ const Fixture = ({
{hasInput && } {hasTextarea &&