Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd Borders on IconButtons in ButtonGroup #3172

Closed
mattcosta7 opened this issue Apr 14, 2023 · 4 comments · Fixed by #3198
Closed

Odd Borders on IconButtons in ButtonGroup #3172

mattcosta7 opened this issue Apr 14, 2023 · 4 comments · Fixed by #3198
Assignees
Labels
bug Something isn't working component: Button Issues related to the Button component design react size: sand

Comments

@mattcosta7
Copy link
Collaborator

Description

Screen.Recording.2023-04-14.at.3.58.56.PM.mov

In a button group, IconButtons seem to have the wrong borders on focus/hover

Steps to reproduce

         <ButtonGroup>
                <IconButton aria-label="" icon={GearIcon} />
                <IconButton aria-label="" icon={SortAscIcon} />
                <IconButton aria-label="" icon={SortAscIcon} />
              </ButtonGroup>
              ```

checkout hover borders

### Version

latest

### Browser

_No response_
@mattcosta7 mattcosta7 added the bug Something isn't working label Apr 14, 2023
@broccolinisoup
Copy link
Member

broccolinisoup commented Apr 17, 2023

Hi 👋 I think this issue might be related to #2933? As far as I understand this behaviour was intentional, at least it was a tradeoff between the wiggly buttons vs border style #2933 cc @langermank

@mattcosta7
Copy link
Collaborator Author

mattcosta7 commented Apr 17, 2023

Hi 👋 I think this issue might be related to #2933? As far as I understand this behaviour was intentional, at least it was a tradeoff between the wiggly buttons vs border style #2933 cc @langermank

Interesting. It definitely looks broken now, especially in dark mode.

Maybe we could set the border-left's color to the non-hover color when it's not the first button, so at least the left and right borders are balanced on 'central' buttons?

Something like -

Screenshot 2023-04-17 at 8 17 12 AM

instead of

Screenshot 2023-04-17 at 8 18 01 AM

Or potentailly something with display: inline-table and border-collapse? (not that I have tried it or thoughts on what that would break - just considering alternatives if possible)

@mattcosta7
Copy link
Collaborator Author

mattcosta7 commented Apr 17, 2023

^ the left border fix suggested above would also help out with this case where the focus outline and hover border on separately elements show, and it looks a little off (at least to me)

Screenshot 2023-04-17 at 9 10 12 AM

@lesliecdubs
Copy link
Member

@langermank assigning you to this since you were mentioned above, but give a shout if you need some support!

@joshblack joshblack added the component: Button Issues related to the Button component label Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component: Button Issues related to the Button component design react size: sand
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants