From 4b5b1e061dcebb0ae378b8737938920ef1b82517 Mon Sep 17 00:00:00 2001 From: Kate Higa <16447748+khiga8@users.noreply.github.com> Date: Fri, 26 Apr 2024 17:36:41 +0000 Subject: [PATCH] Remove extra span nesting --- app/components/primer/beta/button.html.erb | 2 +- app/components/primer/beta/button.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/components/primer/beta/button.html.erb b/app/components/primer/beta/button.html.erb index eeb5d8b9cc..dd9b989bf0 100644 --- a/app/components/primer/beta/button.html.erb +++ b/app/components/primer/beta/button.html.erb @@ -10,7 +10,7 @@ <% if @trailing_visual_counter %> (<%= trailing_visual %>) - + <%= trailing_visual %> <% else %> <%= trailing_visual %> <% end %> diff --git a/app/components/primer/beta/button.rb b/app/components/primer/beta/button.rb index 1bf6d22217..f595c2245a 100644 --- a/app/components/primer/beta/button.rb +++ b/app/components/primer/beta/button.rb @@ -70,7 +70,7 @@ class Button < Primer::Component label: Primer::Beta::Label, counter: lambda { |**system_arguments| @trailing_visual_counter = true - Primer::Beta::Counter.new(**system_arguments) + Primer::Beta::Counter.new("aria-hidden": true, **system_arguments) } }