-
-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VS Code breakpoint with tsx and Nodejs 20.12.0 does not work #506
Comments
Is the reproduction information not enough? |
Took a glance and the first few pages of files I scrolled had nothing to do with tsx or VSCode. |
Hi @privatenumber . Thank you for developing. I can reproduce in the minimal project. VSCode cannot stop at the breakpoints via Node 20.12.0. However, it can do via Node 20.11.1.
Both Node 21 and 20 are not working at tsx when debugging... |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Thanks @tenpaMk2 Would you or @piquark6046 be willing to investigate this? I'm not personally affected by this so I'm unlikely to work on it unless paid to. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment has been minimized.
This comment has been minimized.
This is a project I work on for fun, primarily to improve my own workflow. I'm not currently affected by this (maybe in the future), and it makes more sense for those that are affected by it to fix it. I already donate my time to open source and maintain tsx to help others, and I'm not trying to take on more unpaid work. I'd be happy to review and help you with your PR though. |
It seems that the root cause is because inline sourcemap no longer works in nodejs 20.12.0. VSCode debug might not work if there is no inline sourcemap.
Hope this helps you. |
Ah very helpful @cenfun, great work! Would you be willing to open a PR? |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
I can confirm this behavior, and I'll add that I can also reproduce with the |
@bqp-articulate there is PR here #517 |
@privatenumber I create a new PR here #518 |
This comment was marked as outdated.
This comment was marked as outdated.
Released in v4.7.2! Thanks for your contribution @cenfun 🙌! |
I tested 4.7.2 on my end, works great. Thanks all! |
Acknowledgements
Minimal reproduction URL
List-KR/multithread-array#1
Version
4.7.1
Node.js version
20.12.0
Package manager
npm
Operating system
Linux
Problem & expected behavior (under 200 words)
What happened: All VS Code breakpoints are ignored
What I expected: VS Code breakpoint works as using Node.js 20.11.1
Screenshot:
Screenshot
devcontainer.json
Contributions
The text was updated successfully, but these errors were encountered: