Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error When Canceling Bulk PDF Export Due to Incorrect Handling of Return Type from bridge().showOpenDialog() #280

Open
SyedAyaanAli6786 opened this issue Aug 15, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@SyedAyaanAli6786
Copy link

Operating system

Linux

Joplin version

3.0.13

Desktop version info

No response

Current behaviour

Current Behavior

  • When selecting multiple notes for PDF export, if the user clicks "Export" > "PDF" and then cancels the operation, an error dialog is displayed.
  • This error occurs because the code expects a string from bridge().showOpenDialog(), but receives an empty array instead, leading to a failure in processing the cancellation.

Expected behaviour

Expected Behavior

  • When the user cancels the bulk PDF export by clicking "Cancel," no error dialog should be shown.
  • The application should correctly handle the return value of bridge().showOpenDialog(), accounting for the possibility of receiving an empty array.
  • If the user proceeds with the export, the application should correctly export the selected notes to the specified directory without any errors.

Logs

No response

@SyedAyaanAli6786 SyedAyaanAli6786 added the bug Something isn't working label Aug 15, 2024
@SyedAyaanAli6786
Copy link
Author

@priyasirohi09 Can you assign this issue to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant