Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add diskcache hard autoreload #892

Merged
merged 2 commits into from
Dec 10, 2024
Merged

fix: Add diskcache hard autoreload #892

merged 2 commits into from
Dec 10, 2024

Conversation

thomass-dev
Copy link
Collaborator

Closes #887

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Coverage

pytest coverage report
FileStmtsMissCoverMissing
src/skore
   __init__.py180100% 
   __main__.py811 80%
   exceptions.py40100% 
src/skore/cli
   __init__.py80100% 
   cli.py320100% 
   launch_dashboard.py22120 42%
   quickstart_command.py1220 83%
src/skore/item
   __init__.py2211 92%
   cross_validation_aggregation_item.py4613 93%
   cross_validation_item.py5731 95%
   item.py2210 95%
   item_repository.py4321 94%
   media_item.py6041 93%
   numpy_array_item.py2111 92%
   pandas_dataframe_item.py3011 94%
   pandas_series_item.py3011 94%
   polars_dataframe_item.py2811 94%
   polars_series_item.py2311 93%
   primitive_item.py2321 91%
   sklearn_base_estimator_item.py2911 94%
   skrub_table_report_item.py1011 86%
src/skore/persistence
   __init__.py00100% 
   abstract_storage.py2210 95%
   disk_cache_storage.py3311 95%
   in_memory_storage.py200100% 
src/skore/project
   __init__.py40100% 
   create.py5080 88%
   load.py2330 89%
   project.py6322 95%
src/skore/sklearn
   __init__.py30100% 
   find_ml_task.py1923 85%
   types.py20100% 
src/skore/sklearn/cross_validation
   __init__.py20100% 
   cross_validation_helpers.py4041 89%
   cross_validation_reporter.py2721 90%
   plot.py3814 90%
src/skore/sklearn/train_test_split
   __init__.py00100% 
   train_test_split.py3411 96%
src/skore/sklearn/train_test_split/warning
   __init__.py80100% 
   high_class_imbalance_too_few_examples_warning.py1732 78%
   high_class_imbalance_warning.py1821 88%
   random_state_unset_warning.py1111 87%
   shuffle_true_warning.py901 91%
   stratify_is_set_warning.py1111 87%
   time_based_column_warning.py2212 89%
   train_test_split_warning.py510 80%
src/skore/ui
   __init__.py00100% 
   app.py2552 71%
   dependencies.py710 86%
   project_routes.py8552 92%
src/skore/utils
   __init__.py00100% 
   _show_versions.py290100% 
src/skore/view
   __init__.py00100% 
   view.py50100% 
   view_repository.py1621 83%
TOTAL11968391% 

Tests Skipped Failures Errors Time
171 0 💤 0 ❌ 0 🔥 37.859s ⏱️

@thomass-dev thomass-dev changed the title fix: Add diskcache autoreload fix: Add diskcache hard autoreload Dec 9, 2024
@thomass-dev thomass-dev marked this pull request as ready for review December 9, 2024 15:48
@thomass-dev thomass-dev marked this pull request as draft December 9, 2024 16:01
@thomass-dev thomass-dev force-pushed the autoreload-diskcache branch 3 times, most recently from ef10599 to 7873079 Compare December 9, 2024 16:40
@rouk1
Copy link
Contributor

rouk1 commented Dec 10, 2024

To me this a good feature to have especially now that we have an overwrite flag.
LGTM

@thomass-dev thomass-dev marked this pull request as ready for review December 10, 2024 09:01
@rouk1 rouk1 merged commit 01644dc into main Dec 10, 2024
19 checks passed
@rouk1 rouk1 deleted the autoreload-diskcache branch December 10, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skore UI doesn't show the database content
2 participants