Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate replacing "homegrown" code, with the use of addr2line #1670

Closed
noppej opened this issue Jul 13, 2023 · 3 comments
Closed

Investigate replacing "homegrown" code, with the use of addr2line #1670

noppej opened this issue Jul 13, 2023 · 3 comments
Labels
hygiene Tasks related to improving code efficiency, readability, etc.

Comments

@noppej
Copy link
Contributor

noppej commented Jul 13, 2023

The probe-rs::debug module contains code which can likely be superseded by the use of the addr2line repo.

We already rely heavily on the gimli crate from the same organization, and experience has shown that their api's are fast and reliable.

@Yatekii and @Tiwalun : Please let me have a 👍 or 👎 on this, along with other suggestions you may have.

@noppej noppej added the hygiene Tasks related to improving code efficiency, readability, etc. label Jul 13, 2023
@Yatekii
Copy link
Member

Yatekii commented Jul 13, 2023

I think addr2line had some flaws back in the day, but I do not fully recall.

@bugadani
Copy link
Contributor

One such flaw with addr2line is that it's trying to resolve symbols a bit too eagerly. See this espflash issue for an example

@noppej
Copy link
Contributor Author

noppej commented Feb 25, 2024

Yeah, I literally looked at it as part of refactoring in #2180 , and had to back out because of what you said @bugadani , and also because we also need line-2-addr, with some very specific requirements. I'm closing this for now :)

@noppej noppej closed this as completed Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hygiene Tasks related to improving code efficiency, readability, etc.
Projects
None yet
Development

No branches or pull requests

3 participants