Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance for large sample sizes #30

Open
longouyang opened this issue Jun 14, 2016 · 3 comments
Open

Improve performance for large sample sizes #30

longouyang opened this issue Jun 14, 2016 · 3 comments

Comments

@longouyang
Copy link
Member

No description provided.

@hawkrobe
Copy link

Any ideas on how to start on this? Calling viz.marginals on a probmods example with >100,000 samples (and four variables in the joint distribution) takes an order of magnitude more time than inference

@longouyang
Copy link
Member Author

There are a couple of bottlenecks:

  1. The projected-out distributions are computed in a concise but inefficient way
  2. Density estimation for continuous data is implemented naively. There are various tricks (e.g., FFT and tree-based computation, other stuff) to make this faster but it might not be worth the effort, given that we'll probably want kernel-based aggregators in core webppl anyway (Thoughts on design of aggregators / marginal ERPs webppl#369). Also, if I had to guess, the main bottleneck is probably the projection, not kde.

@hawkrobe
Copy link

Thanks for the tips -- I might take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants