Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor is a focus trap #3085

Closed
sampottinger opened this issue Apr 12, 2024 · 2 comments · Fixed by #3114
Closed

Editor is a focus trap #3085

sampottinger opened this issue Apr 12, 2024 · 2 comments · Fixed by #3114
Labels
Area:Accessibility Category for accessibility related features and bugs Bug Priority:High

Comments

@sampottinger
Copy link

sampottinger commented Apr 12, 2024

p5.js version

N/A (Online Editor)

What is your operating system?

Linux

Web browser and version

Firefox 142

Actual Behavior

Entering the editor is possible with the keyboard but it isn't possible to leave it using the escape key. This is a "focus trap" which is covered in WCAG 2.1.2.

Expected Behavior

This may be a possible hint for fixing in a recent change in ACE editor behavior which is resolved recently in ajaxorg/ace#5114

Steps to reproduce

Steps:

  1. Open the p5.js web editor
  2. Give the code editor focus
  3. Try to leave the code editor
@sampottinger
Copy link
Author

See https://codeberg.org/sketchingpy/Sketchingpy/pulls/65/files for example of recent fix we saw on https://sketchingpy.org

@raclim raclim added the Area:Accessibility Category for accessibility related features and bugs label Apr 13, 2024
@raclim
Copy link
Collaborator

raclim commented Apr 13, 2024

Thanks for raising this and suggesting a potential fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:Accessibility Category for accessibility related features and bugs Bug Priority:High
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants