Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space oddities in .java code generated by preprocessor #607

Closed
benfry opened this issue Nov 27, 2022 · 2 comments
Closed

Space oddities in .java code generated by preprocessor #607

benfry opened this issue Nov 27, 2022 · 2 comments

Comments

@benfry
Copy link
Owner

benfry commented Nov 27, 2022

A few oddities in the generated code from the preprocessor that should be easy to fix. @sampottinger You mentioned you might look at preproc things today, I'm hoping these might be quick?

  • There's an extra space character added before functions (perhaps only functions where public has been added? not sure).
  • Several extra blank lines of text appear toward the top of the file (after imports and before public class iirc)
  • None of the rest of the code is indented at all: i.e. once the sketch is wrapped in public class Blah extends PApplet, the inner lines have no indent.

I'd also like to rewrite the “exported at” text, but can take care of that.

@benfry
Copy link
Owner Author

benfry commented Nov 28, 2022

Closing as resolved with #609.

@benfry benfry closed this as completed Nov 28, 2022
@github-actions
Copy link

This issue has been automatically locked. To avoid confusion with reports that have already been resolved, closed issues are automatically locked 30 days after the last comment. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant