Use getMainName on PreprocService #637
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is working for me (I ran your example) but wouldn't hurt if you checked that it looked ok on your end @benfry. Thanks! |
|
Tried a few different “bad” sketch names and this is still working. This change should align the behavior in preproc service to the full build. Thanks for your patience! |
|
I can also check this later today with the sketch where the problem first occurred for me. But this looks very good! Thank you 🙏 |
|
Awesome; thanks. At some point last night I woke up and was like “oh, it's Appreciate the help! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #610.