Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release? #43

Open
Klaus-Tockloth opened this issue May 5, 2019 · 9 comments
Open

New release? #43

Klaus-Tockloth opened this issue May 5, 2019 · 9 comments

Comments

@Klaus-Tockloth
Copy link

I plan to port this lib to Go and want to do this on a stable release. What's the status of master? Is it stable? Does it make for you to release a new version? The current release v1.0.0 is from 01/2017.

@DanielJDufour
Copy link
Collaborator

Hi. Thanks for getting in touch. I love your idea!

I'm working on fixing the bugs listed under issues. It shouldn't take more than a few weeks. Once that's complete, I'll request that a new release be made. The API shouldn't change, but internally I'd except some changes.

@Klaus-Tockloth
Copy link
Author

I'm working on fixing the bugs listed under issues. It shouldn't take more than a few weeks. Once that's complete, I'll request that a new release be made.

Sounds good. Nevertheless I have started the port to Go (probably including all bugs). First results are a package library and an executable utility. Not everything is ported 1 to 1. I have omitted the 'invers' method because the use case was unclear for me.

@nboisteault
Copy link

@DanielJDufour Could you please make a new release? This useful commit is not in 1.0.0 release.
Thanks.

@DanielJDufour
Copy link
Collaborator

Hi, @calvinmetcalf . Would you be able to add me as a maintainer on NPM, so I can publish a new release? Here's the link for your convenience: https://www.npmjs.com/package/mgrs/access. My NPM username is danieljdufour. Thank you.

@calvinmetcalf
Copy link
Member

invite sent

@DanielJDufour
Copy link
Collaborator

I just published a prerelease. You can install it with npm install mgrs@next. @nboisteault , could you try installing and running it? Let me know if it works for you. Once it's confirmed that the prerelease works, I can publish a new release.

@nboisteault
Copy link

Hi @DanielJDufour ,
I installed and ran and everything worked, thank you!
I'd like to make some PRs. Do you want to wait for them or do you want to publish a new release?

@nboisteault
Copy link

Hi @DanielJDufour ,
Is there any plan to make a release?

@DanielJDufour
Copy link
Collaborator

Hi, @nboisteault . I just published a new major version release. Pull requests are most welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants