Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] TC_EEVSE_2_3 does not run on EST timezone #35623

Closed
andy31415 opened this issue Sep 17, 2024 · 2 comments · Fixed by #36500
Closed

[BUG] TC_EEVSE_2_3 does not run on EST timezone #35623

andy31415 opened this issue Sep 17, 2024 · 2 comments · Fixed by #36500
Assignees
Labels
bug Something isn't working needs triage

Comments

@andy31415
Copy link
Contributor

andy31415 commented Sep 17, 2024

Reproduction steps

Running something of the form:

scripts/run_in_python_env.sh out/venv './scripts/tests/run_python_test.py --load-from-env out/test_env.yaml --script src/python_testing/TC_EEVSE_2_3.py'

fails on my machine with:

│      [2024-09-17 09:55:12.771290][TEST][STDOUT]    return fut.result()                                                                                                                                                                             │
│      [2024-09-17 09:55:12.771296][TEST][STDOUT]           ^^^^^^^^^^^^                                                                                                                                                                             │
│      [2024-09-17 09:55:12.771301][TEST][STDOUT]  File "/usr/local/google/home/andreilitvin/devel/connectedhomeip/src/python_testing/TC_EEVSE_2_3.py", line 270, in test_TC_EEVSE_2_3                                                               │
│      [2024-09-17 09:55:12.771307][TEST][STDOUT]    asserts.assert_less(next_start_time_epoch_s,                                                                                                                                                    │
│      [2024-09-17 09:55:12.771313][TEST][STDOUT]  File "/usr/local/google/home/andreilitvin/devel/connectedhomeip/out/venv/lib/python3.11/site-packages/mobly/asserts.py", line 191, in assert_less                                                 │
│      [2024-09-17 09:55:12.771319][TEST][STDOUT]    _call_unittest_assertion(                                                                                                                                                                       │
│      [2024-09-17 09:55:12.771325][TEST][STDOUT]  File "/usr/local/google/home/andreilitvin/devel/connectedhomeip/out/venv/lib/python3.11/site-packages/mobly/asserts.py", line 50, in _call_unittest_assertion                                     │
│      [2024-09-17 09:55:12.771331][TEST][STDOUT]    raise signals.TestFailure(my_msg, extras=extras)                                                                                                                                                │
│      [2024-09-17 09:55:12.771337][TEST][STDOUT]mobly.signals.TestFailure: Details=779934015 not less than 779929140, Extras=None

The comparison of times seem to be timezone dependent. This prevents me from being able to "run all CI tests" on my machine.

Bug prevalence

Always

GitHub hash of the SDK that was being used

514e810

@andy31415 andy31415 added bug Something isn't working needs triage labels Sep 17, 2024
@andy31415
Copy link
Contributor Author

Specifically setting TZ=UTC makes the test pass however setting TZ=EST causes the faiulure for me.

@github-actions github-actions bot added the linux label Sep 17, 2024
@andy31415
Copy link
Contributor Author

@jamesharrow could you please check this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants