Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZAP UI should not allow editing storage setting for things that are forced to be external #1086

Closed
bzbarsky-apple opened this issue Jul 26, 2023 · 2 comments
Closed

ZAP UI should not allow editing storage setting for things that are forced to be external #1086

bzbarsky-apple opened this issue Jul 26, 2023 · 2 comments
Assignees
@paulr34 @tbrkollar
Labels
matter Important to Matter SDK

Comments

@bzbarsky-apple
Copy link
Contributor

ZAP has a way to force attributes to be external via SDK settings, but the UI will still allow changing the storage value... which will then be ignored.

The UI should not allow setting things that don't match reality.
@bzbarsky-apple bzbarsky-apple added the matter Important to Matter SDK label Jul 26, 2023
@paulr34
Copy link
Collaborator

paulr34 commented Aug 2, 2023

@YanchengZhou

if the SDK forces "storageOption" to be external then the toggle should be disabled. Let's meet and discuss if you can take this on.

@bzbarsky-apple bzbarsky-apple mentioned this issue Oct 3, 2023
Closed
@paulr34 paulr34 assigned paulr34 and tbrkollar and unassigned paulr34 and ethanzhouyc Oct 16, 2023
@paulr34 paulr34 mentioned this issue Nov 8, 2023
Merged
@paulr34
Copy link
Collaborator

paulr34 commented Nov 14, 2023

#1181

@paulr34 paulr34 closed this as completed Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulr34 paulr34

@tbrkollar tbrkollar

Labels
matter Important to Matter SDK
Projects
Silicon Labs - internal work
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bzbarsky-apple @paulr34 @ethanzhouyc @tbrkollar