Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update decisiontable example to work with xlsx file and fix go tests #82

Merged

Conversation

LakshmiMekala
Copy link
Contributor

1.Modify decision table json to xlsx file
2. Fix failing go tests

@flogo-oss
Copy link

flogo-oss commented Dec 3, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@nareshkumarthota nareshkumarthota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@rameshpolishetti rameshpolishetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LakshmiMekala same flogo.json file exists in two places (dtable/flogo.json & dtable/test/flogo.json). Maintain single flogo.json.

Copy link
Contributor

@rameshpolishetti rameshpolishetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@rameshpolishetti rameshpolishetti merged commit 9132485 into feature-decision-table-example-update Dec 4, 2019
@rameshpolishetti rameshpolishetti deleted the chore-dtable-gotests branch December 4, 2019 08:03
rameshpolishetti pushed a commit that referenced this pull request Dec 6, 2019
* updated example to use store config file

* fixing excelise v2 upgrade

* update decisiontable example to work with xlsx file and fix go tests (#82)

* update decisiontable example to work with xlsx file and fix go tests

* removing duplicated flogo.json from test folder

* updated decision table example readme

* stabilising mod and sum files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants