Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport a fix from upstream to make volumes rprivate by default #239

Closed
rhvgoyal opened this issue Apr 28, 2017 · 4 comments
Closed

Backport a fix from upstream to make volumes rprivate by default #239

rhvgoyal opened this issue Apr 28, 2017 · 4 comments

Comments

@rhvgoyal
Copy link

We need to backport following fix from upstream to make volumes "rprivate" by default.

moby#32851

@rhvgoyal
Copy link
Author

cc @runcom

@runcom
Copy link
Collaborator

runcom commented Apr 29, 2017

@rhvgoyal which branches are going to need this? was #238 meant to address this and this issue is just a placeholder for 1.13.1 and 17.03.1-ce branches? (I didn't fully understood). Meanwhile, I've opened two PRs to port #238 to 1.13.1 and 17.03.1-ce, but again, I'm unsure if we still need moby#32851 in every branch as well, please let me know.

@rhvgoyal
Copy link
Author

rhvgoyal commented May 1, 2017

@runcom

#238 and this PR are two independent fixes. Though problem description remains the same.

This PR is basically fixing a regression introduced by commit

moby@fc7b904

I had noticed that above commit did not make into 1.12.6. So we will need this fix for 1.13.1 and
any branches after that.

@runcom
Copy link
Collaborator

runcom commented May 3, 2017

Backported moby@af8a143 to docker-1.13.1, docker-1.13.1-rhel, docker-17.03.1-ce

@runcom runcom closed this as completed May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants