Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please support Rate Limit in Gateway API #4730

Closed
kahirokunn opened this issue Sep 19, 2022 · 4 comments
Closed

Please support Rate Limit in Gateway API #4730

kahirokunn opened this issue Sep 19, 2022 · 4 comments
Labels
area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. blocked/needs-design Categorizes the issue or PR as blocked because it needs a design document. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@kahirokunn
Copy link

https://github.com/projectcontour/contour/blob/08d87aefcdeba93665b04e8b6a893efc8d9d5671/design/gateway-apis-implementation.md

This design is intended to cover the initial alpha releases of the Gateway API. We will aim to implement the core featureset of the APIs at that point.
We will then work with the upstream community on features that Contour and HTTPProxy currently support, but the Gateway API do not, and how best to represent those features in the APIs.
There are some features that are currently gaps for Contour (wildcard domain names, and exact path matching, for example), and some that Contour supports that the Gateway API do not (websockets, configurable timeouts, header replacement, external auth, rate limiting, and so on).

There was a note like this one year ago, but a year has already passed.
What is the current plan to support Rate Limit in the Gateway API?

It seems that the necessary components to implement Rate Limit, such as Policy Attachment, are already in place.
kubernetes-sigs/gateway-api#326 (comment)

@kahirokunn kahirokunn added kind/feature Categorizes issue or PR as related to a new feature. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. labels Sep 19, 2022
@skriss skriss added the area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. label Sep 19, 2022
@sunjayBhatia
Copy link
Member

Now that Gateway API has extension points as you mention, the next steps for features like this are to come up with a design for "*Policy" CRDs and/or HTTPRoute filter extension CRDs to provide the the relevant configuration options

Some design writeups are in the works and we would appreciate feedback and comments on them

@sunjayBhatia sunjayBhatia added the blocked/needs-design Categorizes the issue or PR as blocked because it needs a design document. label Sep 20, 2022
@kahirokunn
Copy link
Author

That's something to look forward to!

@github-actions
Copy link

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 21, 2022
@github-actions
Copy link

The Contour project currently lacks enough contributors to adequately respond to all Issues.

This bot triages Issues according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, the Issue is closed

You can:

  • Mark this Issue as fresh by commenting
  • Close this Issue
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gateway-api Issues or PRs related to the Gateway (Gateway API working group) API. blocked/needs-design Categorizes the issue or PR as blocked because it needs a design document. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/needs-triage Indicates that an issue needs to be triaged by a project contributor. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

3 participants